Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[BUG HUNT] Fix usergroup modal #1144

Merged
merged 3 commits into from
May 3, 2021
Merged

[BUG HUNT] Fix usergroup modal #1144

merged 3 commits into from
May 3, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Signed-off-by: luanecavalcantizup luane.cavalcanti@zup.com.br

Issue Description

When I first open user group modal to add users, the users list is empty.

Solution

Remove conditional that shows only selected users when search is empty.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup self-assigned this May 3, 2021
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label May 3, 2021
@luanecavalcantizup luanecavalcantizup added the bug Something isn't working label May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #1144 (006a16b) into main (c4acb0f) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 006a16b differs from pull request most recent head 2e8fe48. Consider uploading reports for the commit 2e8fe48 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1144      +/-   ##
============================================
+ Coverage     76.70%   76.88%   +0.17%     
  Complexity     2164     2164              
============================================
  Files          1303     1303              
  Lines         18703    18695       -8     
  Branches       1708     1711       +3     
============================================
+ Hits          14347    14373      +26     
+ Misses         3846     3814      -32     
+ Partials        510      508       -2     
Flag Coverage Δ Complexity Δ
ui 80.05% <ø> (+0.38%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Groups/Tabs/helpers.ts 23.07% <ø> (+3.07%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/index.tsx 69.23% <0.00%> (-2.77%) 0.00% <0.00%> (ø%)
ui/src/modules/Settings/hooks.ts 70.96% <0.00%> (-0.91%) 0.00% <0.00%> (ø%)
ui/src/modules/Workspaces/Menu/MenuItem.tsx 92.30% <0.00%> (-0.55%) 0.00% <0.00%> (ø%)
ui/src/core/providers/base/hooks.ts 83.05% <0.00%> (ø) 0.00% <0.00%> (ø%)
ui/src/core/components/Icon/styled.tsx 83.33% <0.00%> (ø) 0.00% <0.00%> (ø%)
ui/src/modules/Modules/Comparation/Form/styled.ts 92.30% <0.00%> (ø) 0.00% <0.00%> (ø%)
...dentials/Sections/DeploymentConfiguration/Form.tsx
...ials/Sections/DeploymentConfiguration/constants.ts
...entials/Sections/DeploymentConfiguration/styled.ts
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796fd1c...2e8fe48. Read the comment docs.

@fandrade-zup fandrade-zup merged commit 1b64c32 into main May 3, 2021
@fandrade-zup fandrade-zup deleted the fix-usergroup-modal branch May 3, 2021 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants