Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Enhancement/duplicated entities #1169

Merged

Conversation

barbararochazup
Copy link
Contributor

@barbararochazup barbararochazup commented May 6, 2021

Issue Description

Validator when create workpace or circle with a name already exists

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label May 6, 2021
@barbararochazup barbararochazup marked this pull request as draft May 6, 2021 15:26
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1169 (c818ee5) into charlescd-release-1.0.0 (b8e0cca) will increase coverage by 0.01%.
The diff coverage is 68.75%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1169      +/-   ##
=============================================================
+ Coverage                      76.89%   76.90%   +0.01%     
- Complexity                      2177     2189      +12     
=============================================================
  Files                           1307     1309       +2     
  Lines                          18736    18771      +35     
  Branches                        1711     1712       +1     
=============================================================
+ Hits                           14407    14436      +29     
- Misses                          3826     3829       +3     
- Partials                         503      506       +3     
Flag Coverage Δ Complexity Δ
moove 75.33% <78.37%> (+0.03%) 1670.00 <14.00> (+12.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
ui/src/core/providers/circle.ts 89.18% <ø> (ø) 0.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 46.66% <0.00%> (ø) 0.00 <0.00> (ø)
...les/Settings/Credentials/Sections/Webhook/hooks.ts 65.30% <25.00%> (ø) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <33.33%> (ø) 0.00 <0.00> (ø)
...DeleteDeploymentConfigurationByIdInteractorImpl.kt 75.00% <60.00%> (ø) 4.00 <2.00> (+2.00)
...in/io/charlescd/moove/application/CircleService.kt 82.50% <71.42%> (-2.35%) 12.00 <2.00> (+1.00) ⬇️
.../circle/impl/FindAllCirclesSimpleInteractorImpl.kt 80.00% <80.00%> (ø) 5.00 <5.00> (?)
ui/src/modules/Circles/hooks.ts 65.00% <83.33%> (ø) 0.00 <0.00> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc23f44...c818ee5. Read the comment docs.

@barbararochazup barbararochazup marked this pull request as ready for review May 12, 2021 20:24
Copy link

@fandrade-zup fandrade-zup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but need to use plural in messages

moove/web/src/main/resources/locale/messages.properties Outdated Show resolved Hide resolved
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@barbararochazup barbararochazup marked this pull request as draft May 13, 2021 13:37
@barbararochazup barbararochazup self-assigned this May 13, 2021
@barbararochazup barbararochazup marked this pull request as ready for review May 13, 2021 17:15
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Copy link

@fandrade-zup fandrade-zup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barbararochazup barbararochazup merged commit 3792415 into charlescd-release-1.0.0 May 14, 2021
@barbararochazup barbararochazup deleted the enhancement/duplicated-entities branch May 14, 2021 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants