This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
fix namespace override "deadlock" #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
boring-cyborg
bot
added
the
butler
lucasbfernandes
changed the title
angelicalimazup
approved these changes
May 10, 2021
thallesfreitaszup
approved these changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## charlescd-release-1.0.0 #1196 +/- ##
=============================================================
+ Coverage 76.72% 76.74% +0.02%
- Complexity 2164 2169 +5
=============================================================
Files 1304 1304
Lines 18703 18683 -20
Branches 1707 1707
=============================================================
- Hits 14349 14338 -11
+ Misses 3844 3838 -6
+ Partials 510 507 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucas Borges Fernandes lucasbfernandes94@gmail.com
Fixed:
Ao fazer a alteração do namespace de "A" para "B" nas configurações de deployment, depois de já ter uma release em mar aberto não é possível fazer override da release neste circulo, pois já existe outra feita no mesmo circulo em outro namespace. Como não conseguimos fazer undeploy via Charles, acontece um deadlock e acabamos matando o workspace configurado.