Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Bug-Hunting/Fix keycloak delete #1199

Merged
merged 4 commits into from
May 10, 2021

Conversation

thallesfreitaszup
Copy link
Contributor

@thallesfreitaszup thallesfreitaszup commented May 10, 2021

Issue Description

Deletion on keycloak was being based on moove user id, but this id is different of the keycloak user_entity id

Solution

First find user by email on keycloak and then use the user id of keycloak to delete

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added butler Improvements/additions/fixes for butler module. gate moove Improvements/additions/fixes for moove module. labels May 10, 2021
@thallesfreitaszup thallesfreitaszup changed the base branch from main to charlescd-release-1.0.0 May 10, 2021 20:40
@thallesfreitaszup thallesfreitaszup removed butler Improvements/additions/fixes for butler module. gate labels May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1199 (57b569e) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.03%.
The diff coverage is 88.18%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1199      +/-   ##
=============================================================
+ Coverage                      76.72%   76.75%   +0.03%     
- Complexity                      2164     2169       +5     
=============================================================
  Files                           1304     1305       +1     
  Lines                          18703    18706       +3     
  Branches                        1707     1709       +2     
=============================================================
+ Hits                           14349    14357       +8     
+ Misses                          3844     3842       -2     
+ Partials                         510      507       -3     
Flag Coverage Δ Complexity Δ
moove 75.22% <97.14%> (+0.10%) 1650.00 <8.00> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
...rastructure/service/client/response/LogResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Form/InputTitle/index.tsx 93.33% <ø> (-1.91%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/mocks/handlers/circles/responses.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Circles/Comparation/Item/styled.ts 78.26% <ø> (ø) 0.00 <0.00> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9238441...57b569e. Read the comment docs.

@thallesfreitaszup thallesfreitaszup merged commit 6246311 into charlescd-release-1.0.0 May 10, 2021
@thallesfreitaszup thallesfreitaszup deleted the fix-keycloak-delete branch May 10, 2021 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants