Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[BUG HUNT] Add notification on module deletion #1200

Merged
merged 10 commits into from
May 12, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented May 10, 2021

When a module is deleted, show a notification in screen.

Screenshot (after)

image

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup self-assigned this May 10, 2021
@boring-cyborg boring-cyborg bot added butler Improvements/additions/fixes for butler module. gate labels May 10, 2021
@luanecavalcantizup luanecavalcantizup changed the base branch from main to charlescd-release-1.0.0 May 10, 2021 21:05
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1200 (5e0608a) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.14%.
The diff coverage is 89.72%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1200      +/-   ##
=============================================================
+ Coverage                      76.72%   76.86%   +0.14%     
- Complexity                      2164     2169       +5     
=============================================================
  Files                           1304     1307       +3     
  Lines                          18703    18709       +6     
  Branches                        1707     1709       +2     
=============================================================
+ Hits                           14349    14381      +32     
+ Misses                          3844     3824      -20     
+ Partials                         510      504       -6     
Flag Coverage Δ Complexity Δ
ui 79.93% <88.16%> (+0.23%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
...rastructure/service/client/response/LogResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Form/InputTitle/index.tsx 93.33% <ø> (-1.91%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Account/index.tsx 70.27% <0.00%> (ø) 0.00 <0.00> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e1670...5e0608a. Read the comment docs.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review May 11, 2021 17:26
ui/src/mocks/handlers/modules/index.ts Outdated Show resolved Hide resolved
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup merged commit 4f96da8 into charlescd-release-1.0.0 May 12, 2021
@luanecavalcantizup luanecavalcantizup deleted the fix-module-notification branch May 12, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-hunting butler Improvements/additions/fixes for butler module. gate ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants