Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Returning correct error when helm url is invalid #1201

Merged
merged 2 commits into from
May 12, 2021

Conversation

lucasbfernandes
Copy link
Contributor

Fix:

[BACK] Quando helmUrl é inválido e tento fazer um deploy, /moove/v2/deployments responde com erro 500

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label May 10, 2021
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1201 (adceff6) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1201      +/-   ##
=============================================================
+ Coverage                      76.72%   76.74%   +0.02%     
- Complexity                      2164     2169       +5     
=============================================================
  Files                           1304     1305       +1     
  Lines                          18703    18702       -1     
  Branches                        1707     1709       +2     
=============================================================
+ Hits                           14349    14353       +4     
+ Misses                          3844     3842       -2     
+ Partials                         510      507       -3     
Flag Coverage Δ Complexity Δ
butler 84.44% <93.10%> (+0.08%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
...rastructure/service/client/response/LogResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Form/InputTitle/index.tsx 93.33% <ø> (-1.91%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/mocks/handlers/circles/responses.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Account/index.tsx 70.27% <0.00%> (ø) 0.00 <0.00> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d369d...adceff6. Read the comment docs.

@angelicalimazup angelicalimazup merged commit 1524dcc into charlescd-release-1.0.0 May 12, 2021
@angelicalimazup angelicalimazup deleted the fix-moove-butler-helm-err branch May 12, 2021 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants