Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[BUG HUNT] Disable button on deploy #1213

Merged
merged 3 commits into from
May 12, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Disable Deploy button on deploy, so a user cannot make same request twice.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup added ui Improvements/additions/fixes for ui module. bug-hunting labels May 12, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1213 (5628e5e) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.04%.
The diff coverage is 88.07%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1213      +/-   ##
=============================================================
+ Coverage                      76.72%   76.76%   +0.04%     
- Complexity                      2164     2175      +11     
=============================================================
  Files                           1304     1305       +1     
  Lines                          18703    18719      +16     
  Branches                        1707     1711       +4     
=============================================================
+ Hits                           14349    14370      +21     
+ Misses                          3844     3843       -1     
+ Partials                         510      506       -4     
Flag Coverage Δ Complexity Δ
ui 79.67% <84.66%> (-0.03%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...i/deployments/controller/deployments.controller.ts 86.11% <ø> (ø) 0.00 <0.00> (ø)
...eployments/pipes/default-circle-uniqueness.pipe.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
...rastructure/service/client/response/LogResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Form/InputTitle/index.tsx 93.33% <ø> (-1.91%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70434bf...5628e5e. Read the comment docs.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review May 12, 2021 13:00
@luanecavalcantizup luanecavalcantizup merged commit 8ccdcc1 into charlescd-release-1.0.0 May 12, 2021
@luanecavalcantizup luanecavalcantizup deleted the fix-deploy-button branch May 12, 2021 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-hunting ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants