Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Change logs Set to List to garantee order #1219

Merged

Conversation

leandrorodrigueszup
Copy link
Contributor

Butler sends back to moove the logs list sorted by date. But moove is managing the logs using a Set (the has no order garanted). Changing to List

Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1219 (7a52ca5) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.15%.
The diff coverage is 89.79%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1219      +/-   ##
=============================================================
+ Coverage                      76.72%   76.87%   +0.15%     
- Complexity                      2164     2177      +13     
=============================================================
  Files                           1304     1307       +3     
  Lines                          18703    18735      +32     
  Branches                        1707     1711       +4     
=============================================================
+ Hits                           14349    14403      +54     
+ Misses                          3844     3829      -15     
+ Partials                         510      503       -7     
Flag Coverage Δ Complexity Δ
moove 75.30% <98.21%> (+0.18%) 1658.00 <13.00> (+13.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...i/deployments/controller/deployments.controller.ts 86.11% <ø> (ø) 0.00 <0.00> (ø)
...eployments/pipes/default-circle-uniqueness.pipe.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Page/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7eff70...7a52ca5. Read the comment docs.

@fandrade-zup fandrade-zup merged commit b906e70 into charlescd-release-1.0.0 May 12, 2021
@fandrade-zup fandrade-zup deleted the bug-hunting/fix-moove-logs-order branch May 12, 2021 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants