Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

adding validation when delete configuration to active deployments #1223

Merged

Conversation

barbararochazup
Copy link
Contributor

Signed-off-by: barbararochazup barbara.rocha@zup.com.br

Issue Description

Verify if exists a deployment when delete a deployment configuration

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label May 13, 2021
@barbararochazup barbararochazup marked this pull request as draft May 13, 2021 17:01
@barbararochazup barbararochazup self-assigned this May 13, 2021
@barbararochazup barbararochazup requested review from monicaribeiro, emiteze and lucasbfernandes and removed request for monicaribeiro May 13, 2021 17:12
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@barbararochazup barbararochazup marked this pull request as ready for review May 13, 2021 17:15
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1223 (18fa35f) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.19%.
The diff coverage is 89.40%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1223      +/-   ##
=============================================================
+ Coverage                      76.72%   76.91%   +0.19%     
- Complexity                      2164     2188      +24     
=============================================================
  Files                           1304     1309       +5     
  Lines                          18703    18767      +64     
  Branches                        1707     1712       +5     
=============================================================
+ Hits                           14349    14434      +85     
+ Misses                          3844     3828      -16     
+ Partials                         510      505       -5     
Flag Coverage Δ Complexity Δ
moove 75.35% <93.65%> (+0.23%) 1669.00 <16.00> (+24.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...i/deployments/controller/deployments.controller.ts 86.11% <ø> (ø) 0.00 <0.00> (ø)
...eployments/pipes/default-circle-uniqueness.pipe.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
...rastructure/service/client/response/LogResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Wizard/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Page/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dd19d...18fa35f. Read the comment docs.

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@barbararochazup barbararochazup merged commit 625bdd8 into charlescd-release-1.0.0 May 13, 2021
@barbararochazup barbararochazup deleted the hotfix/block-config-namespace branch May 13, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants