Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

created new endpoint to find simplified circle data #1226

Merged
merged 4 commits into from
May 13, 2021

Conversation

icaroafonsozup
Copy link
Contributor

Signed-off-by: Icaro Gabriel Marques Afonso icaro.afonso@zup.com.br

Issue Description

The circle list endpoint returns more data than is necessary.

Solution

created a new endpoint at the Circle controller that will return only id and name of a circle.

Results

Request:

Url: GET {{url}}/circles/simple

PArameters:

name= circle name to find (use in Ilike)
except=circle Id to ingnore in filter
pageREquest= page data

Response:

Status: 200 OK

Payload:

 "content": [
        {
            "id": "value",
            "name": "value"
        }
    ],
    "page": value,
    "size": value,
    "totalPages": value,
    "last": value

Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
@icaroafonsozup icaroafonsozup added moove Improvements/additions/fixes for moove module. backend bug-hunting labels May 13, 2021
@icaroafonsozup icaroafonsozup self-assigned this May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1226 (762146c) into charlescd-release-1.0.0 (051cf16) will increase coverage by 0.15%.
The diff coverage is 87.38%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1226      +/-   ##
=============================================================
+ Coverage                      76.72%   76.87%   +0.15%     
- Complexity                      2164     2185      +21     
=============================================================
  Files                           1304     1309       +5     
  Lines                          18703    18735      +32     
  Branches                        1707     1702       -5     
=============================================================
+ Hits                           14349    14402      +53     
+ Misses                          3844     3828      -16     
+ Partials                         510      505       -5     
Flag Coverage Δ Complexity Δ
moove 75.35% <91.22%> (+0.23%) 1666.00 <19.00> (+21.00)
ui 79.89% <86.06%> (+0.19%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Form/InputTitle/index.tsx 93.75% <ø> (-1.49%) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/mocks/handlers/circles/index.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Account/index.tsx 70.27% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Comparation/Item/styled.ts 78.26% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Menu/MenuItem.tsx 66.66% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Tabs/Modal/index.tsx 94.87% <ø> (ø) 0.00 <0.00> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b17ef6...762146c. Read the comment docs.

Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label May 13, 2021
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
@icaroafonsozup icaroafonsozup marked this pull request as ready for review May 13, 2021 20:05
@bCatanant bCatanant merged commit 8ce6f89 into charlescd-release-1.0.0 May 13, 2021
@bCatanant bCatanant deleted the circle-list branch May 13, 2021 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug-hunting moove Improvements/additions/fixes for moove module. ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants