This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Setting butler request size limit for 50mb by default #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
boring-cyborg
bot
added
the
butler
Codecov Report
@@ Coverage Diff @@
## charlescd-release-1.0.0 #1228 +/- ##
==========================================================
Coverage 76.89% 76.89%
Complexity 2177 2177
==========================================================
Files 1307 1306 -1
Lines 18736 18718 -18
Branches 1711 1710 -1
==========================================================
- Hits 14407 14394 -13
+ Misses 3826 3821 -5
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
fandrade-zup
suggested changes
May 13, 2021
| @@ -110,6 +110,8 @@ env: | |||
| value: "http://charlescd-butler.{{ .ChartContext.Release.Namespace }}.svc.cluster.local:3000" | |||
| - name: BUTLER_NAMESPACE | |||
| value: {{ .ChartContext.Release.Namespace }} | |||
| - name: REQUEST_SIZE_LIMIT | |||
| value: {{ .RangeContext.requestSizeLimit }} | |||
There was a problem hiding this comment.
The right way is passing the value in quotes:
value: {{ .RangeContext.requestSizeLimit | default 50mb| quote}}
There was a problem hiding this comment.
fixed here 51713b4
install/helm-chart/values.yaml
Outdated
| @@ -46,6 +46,7 @@ CharlesApplications: | |||
| password: 3f2Yq8R4HhDCnefR | |||
| name: charlescd_butler | |||
| ssl: false | |||
| requestSizeLimit: '50mb' | |||
There was a problem hiding this comment.
Right way is:
requestSizeLimit: 50mb
There was a problem hiding this comment.
fixed here 51713b4
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
thallesfreitaszup
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Request entity too large caused by large payloads sent from metacontroller.