Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Show notification on delete #1229

Merged
merged 5 commits into from
May 14, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Show notification on delete in:
Registry, Deployment Configuration, Circle Matcher, Datasources and User group.

Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
@luanecavalcantizup luanecavalcantizup added ui Improvements/additions/fixes for ui module. bug-hunting labels May 13, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1229 (6f98843) into charlescd-release-1.0.0 (b8e0cca) will decrease coverage by 0.03%.
The diff coverage is 72.22%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1229      +/-   ##
=============================================================
- Coverage                      76.89%   76.85%   -0.04%     
- Complexity                      2177     2185       +8     
=============================================================
  Files                           1307     1309       +2     
  Lines                          18736    18750      +14     
  Branches                        1711     1706       -5     
=============================================================
+ Hits                           14407    14411       +4     
- Misses                          3826     3832       +6     
- Partials                         503      507       +4     
Flag Coverage Δ Complexity Δ
ui 79.85% <59.25%> (-0.07%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...dentials/Sections/DeploymentConfiguration/hooks.ts 45.16% <0.00%> (-1.51%) 0.00 <0.00> (ø)
ui/src/core/providers/circle.ts 82.92% <25.00%> (-6.27%) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <33.33%> (ø) 0.00 <0.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/hooks.ts 60.00% <33.33%> (-4.71%) 0.00 <0.00> (ø)
...tings/Credentials/Sections/MetricProvider/hooks.ts 70.58% <33.33%> (-3.61%) 0.00 <0.00> (ø)
.../circle/impl/FindAllCirclesSimpleInteractorImpl.kt 80.00% <80.00%> (ø) 5.00 <5.00> (?)
...pplication/circle/response/SimpleCircleResponse.kt 85.71% <85.71%> (ø) 2.00 <2.00> (?)
...in/io/charlescd/moove/application/CircleService.kt 86.84% <100.00%> (+1.99%) 12.00 <1.00> (+1.00)
ui/src/modules/Circles/hooks.ts 64.22% <100.00%> (-0.78%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/Form/index.tsx 80.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce6f89...6f98843. Read the comment docs.

@angelicalimazup angelicalimazup merged commit dc23f44 into charlescd-release-1.0.0 May 14, 2021
@angelicalimazup angelicalimazup deleted the show-notification-on-delete branch May 14, 2021 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-hunting ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants