Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix workspace menu #1234

Merged
merged 2 commits into from
May 14, 2021
Merged

Fix workspace menu #1234

merged 2 commits into from
May 14, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Fix : [FRONT] Quando nao existe deployment_configuration cadastrado no workspace, no cadastro de modulo nao aparece o campo de cadastro de helmUrl

Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label May 14, 2021
@luanecavalcantizup luanecavalcantizup marked this pull request as draft May 14, 2021 19:02
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review May 14, 2021 20:07
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1234 (bbf9aa9) into charlescd-release-1.0.0 (18d0ebe) will increase coverage by 0.01%.
The diff coverage is 61.53%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1234      +/-   ##
=============================================================
+ Coverage                      76.85%   76.87%   +0.01%     
- Complexity                      2185     2189       +4     
=============================================================
  Files                           1309     1309              
  Lines                          18751    18794      +43     
  Branches                        1707     1718      +11     
=============================================================
+ Hits                           14412    14448      +36     
- Misses                          3832     3838       +6     
- Partials                         507      508       +1     
Flag Coverage Δ Complexity Δ
ui 79.86% <60.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/io/charlescd/moove/application/CircleService.kt 82.50% <0.00%> (-4.35%) 12.00 <1.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 45.16% <0.00%> (ø) 0.00 <0.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/hooks.ts 60.00% <33.33%> (ø) 0.00 <0.00> (ø)
...tings/Credentials/Sections/MetricProvider/hooks.ts 70.58% <33.33%> (ø) 0.00 <0.00> (ø)
...DeleteDeploymentConfigurationByIdInteractorImpl.kt 75.00% <60.00%> (ø) 4.00 <2.00> (+2.00)
butler/src/app/v2/core/config/configurations.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...o/charlescd/moove/application/DeploymentService.kt 96.29% <100.00%> (+0.14%) 13.00 <1.00> (+1.00)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <100.00%> (ø) 11.00 <2.00> (+1.00)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938ae6f...bbf9aa9. Read the comment docs.

@bCatanant bCatanant merged commit f5c8362 into charlescd-release-1.0.0 May 14, 2021
@bCatanant bCatanant deleted the fix-helm-url branch May 14, 2021 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-hunting ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants