Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Butler skip tls option #1237

Merged
merged 3 commits into from
May 14, 2021
Merged

Conversation

lucasbfernandes
Copy link
Contributor

Adding TLS_SKIP_VERIFY flag inside butler.

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label May 14, 2021
Copy link

@fandrade-zup fandrade-zup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1237 (34d9f6e) into charlescd-release-1.0.0 (18d0ebe) will increase coverage by 0.02%.
The diff coverage is 74.46%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1237      +/-   ##
=============================================================
+ Coverage                      76.85%   76.88%   +0.02%     
- Complexity                      2185     2189       +4     
=============================================================
  Files                           1309     1308       -1     
  Lines                          18751    18785      +34     
  Branches                        1707     1718      +11     
=============================================================
+ Hits                           14412    14443      +31     
- Misses                          3832     3834       +2     
- Partials                         507      508       +1     
Flag Coverage Δ Complexity Δ
butler 84.61% <100.00%> (+0.25%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/io/charlescd/moove/application/CircleService.kt 82.50% <0.00%> (-4.35%) 12.00 <1.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
ui/src/core/components/Form/Number/helper.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/providers/circle.ts 82.92% <0.00%> (ø) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <0.00%> (ø) 0.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 45.16% <0.00%> (ø) 0.00 <0.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/hooks.ts 60.00% <33.33%> (ø) 0.00 <0.00> (ø)
...tings/Credentials/Sections/MetricProvider/hooks.ts 70.58% <33.33%> (ø) 0.00 <0.00> (ø)
...DeleteDeploymentConfigurationByIdInteractorImpl.kt 75.00% <60.00%> (ø) 4.00 <2.00> (+2.00)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcfc0e...34d9f6e. Read the comment docs.

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@lucasbfernandes lucasbfernandes merged commit dc67572 into charlescd-release-1.0.0 May 14, 2021
@lucasbfernandes lucasbfernandes deleted the butler-skip-tls-option branch May 14, 2021 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants