Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[component] Change text in button #1240

Merged
merged 2 commits into from
May 17, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Signed-off-by: Luane Aquino luane.aquino.br@gmail.com

Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
@luanecavalcantizup luanecavalcantizup self-assigned this May 14, 2021
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label May 14, 2021
Signed-off-by: Luane Aquino <luane.aquino.br@gmail.com>
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1240 (1b34afc) into charlescd-release-1.0.0 (18d0ebe) will decrease coverage by 0.03%.
The diff coverage is 64.38%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1240      +/-   ##
=============================================================
- Coverage                      76.85%   76.82%   -0.04%     
  Complexity                      2185     2185              
=============================================================
  Files                           1309     1309              
  Lines                          18751    18770      +19     
  Branches                        1707     1710       +3     
=============================================================
+ Hits                           14412    14420       +8     
- Misses                          3832     3841       +9     
- Partials                         507      509       +2     
Flag Coverage Δ Complexity Δ
ui 79.77% <50.94%> (-0.09%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
...o/charlescd/moove/application/DeploymentService.kt 96.15% <ø> (ø) 12.00 <0.00> (ø)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <ø> (ø) 10.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
ui/src/core/components/Form/Number/helper.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/providers/circle.ts 82.92% <0.00%> (ø) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <0.00%> (ø) 0.00 <0.00> (ø)
...src/modules/Modules/Comparation/Form/Component.tsx 79.48% <ø> (-0.52%) 0.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 45.16% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Settings/index.tsx 71.42% <25.00%> (-6.35%) 0.00 <0.00> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef874...1b34afc. Read the comment docs.

Copy link

@fandrade-zup fandrade-zup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelicalimazup angelicalimazup merged commit 9c4e12b into charlescd-release-1.0.0 May 17, 2021
@angelicalimazup angelicalimazup deleted the fix-component-text branch May 17, 2021 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-hunting ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants