Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[BUG HUNTING] fix deletion of user from user group #1242

Merged

Conversation

thallesfreitaszup
Copy link
Contributor

@thallesfreitaszup thallesfreitaszup commented May 17, 2021

Description

[BACK] Ao tentar deletar um usuário associado á um usergroup, o sistema retorna 500 - mensagem tbm não está amigáve

Signed-off-by: thalles <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label May 17, 2021
@thallesfreitaszup thallesfreitaszup changed the title [BUG HUNTING [BUG HUNTING] fix deletion from user group May 17, 2021
@thallesfreitaszup thallesfreitaszup changed the title [BUG HUNTING] fix deletion from user group [BUG HUNTING] fix deletion of user from user group May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1242 (2d7f461) into charlescd-release-1.0.0 (18d0ebe) will increase coverage by 0.06%.
The diff coverage is 61.53%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1242      +/-   ##
=============================================================
+ Coverage                      76.85%   76.92%   +0.06%     
- Complexity                      2185     2195      +10     
=============================================================
  Files                           1309     1309              
  Lines                          18751    18783      +32     
  Branches                        1707     1712       +5     
=============================================================
+ Hits                           14412    14448      +36     
+ Misses                          3832     3829       -3     
+ Partials                         507      506       -1     
Flag Coverage Δ Complexity Δ
moove 75.38% <71.42%> (+0.03%) 1676.00 <7.00> (+10.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/io/charlescd/moove/application/CircleService.kt 82.50% <0.00%> (-4.35%) 12.00 <1.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 46.66% <0.00%> (+1.50%) 0.00 <0.00> (ø)
...DeleteDeploymentConfigurationByIdInteractorImpl.kt 75.00% <60.00%> (ø) 4.00 <2.00> (+2.00)
butler/src/app/v2/core/config/configurations.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...o/charlescd/moove/application/DeploymentService.kt 96.29% <100.00%> (+0.14%) 13.00 <1.00> (+1.00)
...io/charlescd/moove/application/WorkspaceService.kt 100.00% <100.00%> (ø) 11.00 <2.00> (+1.00)
...cd/moove/legacy/moove/service/UserServiceLegacy.kt 82.92% <100.00%> (+1.34%) 16.00 <1.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/hooks.ts 64.70% <100.00%> (+4.70%) 0.00 <0.00> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938ae6f...2d7f461. Read the comment docs.

@barbararochazup barbararochazup merged commit cf11f0f into charlescd-release-1.0.0 May 17, 2021
@barbararochazup barbararochazup deleted the bug-hunting/fix-deletion-usergroup branch May 17, 2021 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants