Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

adding deployment active on patch workspace to remove deployment config #1243

Conversation

barbararochazup
Copy link
Contributor

Signed-off-by: barbararochazup barbara.rocha@zup.com.br

Issue Description

Adding validation to patch workspace when remove a configuration id to not remove when have a active deployment

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label May 17, 2021
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1243 (a093cd4) into charlescd-release-1.0.0 (18d0ebe) will increase coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1243      +/-   ##
=============================================================
+ Coverage                      76.85%   76.92%   +0.06%     
- Complexity                      2185     2203      +18     
=============================================================
  Files                           1309     1309              
  Lines                          18751    18789      +38     
  Branches                        1707     1713       +6     
=============================================================
+ Hits                           14412    14454      +42     
+ Misses                          3832     3829       -3     
+ Partials                         507      506       -1     
Flag Coverage Δ Complexity Δ
moove 75.41% <80.00%> (+0.05%) 1684.00 <19.00> (+18.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/io/charlescd/moove/application/CircleService.kt 82.50% <0.00%> (-4.35%) 12.00 <1.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
ui/src/core/components/Form/Number/helper.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/providers/circle.ts 89.18% <ø> (+6.26%) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <0.00%> (ø) 0.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 46.66% <0.00%> (+1.50%) 0.00 <0.00> (ø)
...DeleteDeploymentConfigurationByIdInteractorImpl.kt 75.00% <60.00%> (ø) 4.00 <2.00> (+2.00)
...es/Settings/Credentials/Sections/Webhook/index.tsx 74.07% <62.50%> (ø) 0.00 <0.00> (ø)
...tings/Credentials/Sections/CircleMatcher/index.tsx 62.06% <66.66%> (ø) 0.00 <0.00> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19067c9...a093cd4. Read the comment docs.

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@barbararochazup barbararochazup merged commit 2750397 into charlescd-release-1.0.0 May 17, 2021
@barbararochazup barbararochazup deleted the hotfix/patch-workspace-deployment-config branch May 17, 2021 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants