Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

validate uppercase tags #1246

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

thallesfreitaszup
Copy link
Contributor

@thallesfreitaszup thallesfreitaszup commented May 17, 2021

Signed-off-by: thalles thalles.freitas@zup.com.br

Description

solves #917

Signed-off-by: thalles <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1246 (eb4ec85) into charlescd-release-1.0.0 (18d0ebe) will increase coverage by 0.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1246      +/-   ##
=============================================================
+ Coverage                      76.85%   76.87%   +0.01%     
- Complexity                      2185     2195      +10     
=============================================================
  Files                           1309     1308       -1     
  Lines                          18751    18820      +69     
  Branches                        1707     1723      +16     
=============================================================
+ Hits                           14412    14467      +55     
- Misses                          3832     3843      +11     
- Partials                         507      510       +3     
Flag Coverage Δ Complexity Δ
butler 84.65% <100.00%> (+0.29%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/io/charlescd/moove/application/CircleService.kt 82.50% <0.00%> (-4.35%) 12.00 <1.00> (ø)
...oove/application/DeploymentConfigurationService.kt 85.71% <ø> (ø) 5.00 <0.00> (ø)
.../application/circle/request/CreateCircleRequest.kt 91.30% <ø> (ø) 2.00 <0.00> (ø)
ui/src/core/components/Form/Number/helper.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/providers/circle.ts 82.92% <0.00%> (ø) 0.00 <0.00> (ø)
...rcles/Comparation/Item/MetricsGroups/AddAction.tsx 67.30% <0.00%> (ø) 0.00 <0.00> (ø)
...src/modules/Modules/Comparation/Form/Component.tsx 79.48% <ø> (-0.52%) 0.00 <0.00> (ø)
...dentials/Sections/DeploymentConfiguration/hooks.ts 45.16% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Settings/index.tsx 71.42% <25.00%> (-6.35%) 0.00 <0.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/hooks.ts 60.00% <33.33%> (ø) 0.00 <0.00> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf11f0f...eb4ec85. Read the comment docs.

Signed-off-by: thalles <thalles.freitas@zup.com.br>
@angelicalimazup angelicalimazup merged commit bd0b2ae into charlescd-release-1.0.0 May 17, 2021
@angelicalimazup angelicalimazup deleted the bh-fix-uppercase-tags branch May 17, 2021 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants