Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Auth and token is now nullable #1278

Merged

Conversation

gabrielleitezup
Copy link
Contributor

Signed-off-by: Gabriel Leite gabriel.leite@zup.com.br

Issue Description

Token and Authorization param in CSV endpoins wasn't nullable.

Signed-off-by: Gabriel Leite <gabriel.leite@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Jun 1, 2021
@gabrielleitezup gabrielleitezup self-assigned this Jun 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1278 (539c72b) into charlescd-release-1.0.0 (c476a04) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             charlescd-release-1.0.0    #1278      +/-   ##
=============================================================
+ Coverage                      76.71%   76.81%   +0.09%     
- Complexity                      2203     2212       +9     
=============================================================
  Files                           1329     1308      -21     
  Lines                          19934    18889    -1045     
  Branches                        1724     1725       +1     
=============================================================
- Hits                           15293    14510     -783     
+ Misses                          4085     3867     -218     
+ Partials                         556      512      -44     
Flag Coverage Δ
compass ?
moove 75.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
compass/internal/dispatcher/actiondispatcher.go
compass/internal/metric/metricexecution.go
compass/internal/action/main.go
compass/internal/metric/main.go
compass/internal/plugin/main.go
compass/internal/dispatcher/dispatcher.go
compass/internal/plugin/plugin.go
.../internal/metricsgroupaction/metricsgroupaction.go
compass/internal/action/queries.go
...ass/internal/metricsgroupaction/actionexecution.go
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c476a04...539c72b. Read the comment docs.

@barbararochazup barbararochazup linked an issue Jun 1, 2021 that may be closed by this pull request
@barbararochazup barbararochazup changed the base branch from charlescd-release-1.0.0 to hotfix/charlescd-release-1.0.1 June 10, 2021 12:21
@barbararochazup barbararochazup merged commit f333fe5 into hotfix/charlescd-release-1.0.1 Jun 10, 2021
@barbararochazup barbararochazup deleted the moove/circleCsv-nullable-auth branch June 10, 2021 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating a segmentation by csv
4 participants