Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fixing docker registry component tag search #241

Merged
merged 41 commits into from
Jul 10, 2020
Merged

fixing docker registry component tag search #241

merged 41 commits into from
Jul 10, 2020

Conversation

adauto
Copy link
Contributor

@adauto adauto commented Jul 3, 2020

  • This pull request aims to fix the bug of component's image tag search on Villager and Moove modules

adauto and others added 7 commits July 2, 2020 17:34
@adauto
Changing 'get component tag' service to return one specific tag inste…
c85f033 
…ad of a list

Signed-off-by: AdauT_0 <aragorn1308@gmail.com>
@adautopaulazup
Removing unused docker image tag list structures
690632e 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Merge branch 'master' of github.com:ZupIT/charlescd into fix/docker-r…
845e2e2 
…egistry-tag-search
@adautopaulazup
Revert "Removing unused docker image tag list structures"
e114817 
This reverts commit 690632e.
@adautopaulazup
Changing the return type of the 'get docker image tag'
cdd99bc 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Adding component tag name parameter to find component service controller
64f1eb7 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Removing get docker image list method from registry client
9a3160c 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@boring-cyborg boring-cyborg bot added moove Improvements/additions/fixes for moove module. villager Improvements/additions/fixes for villager module. labels Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020 •
edited

Codecov Report

Merging #241 into master will increase coverage by 1.02%.
The diff coverage is 83.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     51.51%   52.54%   +1.02%     
+ Complexity     1480     1479       -1     
============================================
  Files          1018     1018              
  Lines         14385    14381       -4     
  Branches       1177     1179       +2     
============================================
+ Hits           7411     7556     +145     
+ Misses         6688     6528     -160     
- Partials        286      297      +11
Flag Coverage Δ Complexity Δ
#moove 57.16% <100.00%> (+0.01%) 1213.00 <0.00> (ø)
#ui 42.43% <94.28%> (+2.49%) 0.00 <0.00> (ø)
#villager 40.32% <66.66%> (+1.44%) 104.00 <6.00> (-1.00) ⬆️
Impacted Files Coverage Δ Complexity Δ
ui/src/core/assets/themes/input.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/Create/helpers.ts 60.60% <ø> (+39.39%) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/Search/index.tsx 70.83% <ø> (+66.66%) 0.00 <0.00> (ø)
...api/resources/registry/DockerRegistryResource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ration/registry/DockerRegistryHttpApiV2Client.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/hooks.ts 90.00% <83.33%> (+70.00%) 0.00 <0.00> (ø)
...istry/impl/GetDockerRegistryTagInteractorImpl.java 95.00% <87.50%> (ø) 5.00 <2.00> (?)
...ion/module/impl/FindComponentTagsInteractorImpl.kt 93.33% <100.00%> (+0.47%) 6.00 <0.00> (ø)
...ve/infrastructure/service/VillagerClientService.kt 61.81% <100.00%> (+0.70%) 14.00 <0.00> (ø)
ui/src/core/components/Form/Input/index.tsx 81.81% <100.00%> (+0.86%) 0.00 <0.00> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c5d72...b8ac247. Read the comment docs.

@adautopaulazup
Adding whitespace between parameter name and type to prevent ktlint e…
ba7fead 
…rrors

Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Fixing ktlint issues
1ef5e2b 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adauto adauto mentioned this pull request Jul 3, 2020
Closed
@adauto adauto added the ui Improvements/additions/fixes for ui module. label Jul 6, 2020
Leandroqo and others added 16 commits July 6, 2020 10:32
@Leandroqo
Merge branch 'master' of https://github.com/ZupIT/charlescd into fix/…
eb0c472 
…docker-registry-tag-search
@ricardorames
Merge branch 'master' into fix/docker-registry-tag-search
b07d88f
@Leandroqo
Merge branch 'master' of https://github.com/ZupIT/charlescd into fix/…
dd484c1 
…docker-registry-tag-search
@Leandroqo
change module version type to input
cf71149 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
Merge branch 'master' of https://github.com/ZupIT/charlescd into fix/…
55e8c5a 
…docker-registry-tag-search
@adautopaulazup
Add http status validation to get docker image method
e57acd9 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Merge branch 'master' of github.com:ZupIT/charlescd into fix/docker-r…
d8102f9 
…egistry-tag-search
@adautopaulazup
Merge branch 'fix/docker-registry-tag-search' of github.com:ZupIT/cha…
4afb1ea 
…rlescd into fix/docker-registry-tag-search
@adauto
Merge branch 'master' into fix/docker-registry-tag-search
a6b1cd6
@Leandroqo
Merge branch 'fix/docker-registry-tag-search' of https://github.com/Z…
00a42c5 
…upIT/charlescd into fix/docker-registry-tag-search
@Leandroqo
change way to request tags
d269f6b 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
check version exists
b558e52 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
Merge branch 'master' of https://github.com/ZupIT/charlescd into fix/…
5ed5c63 
…docker-registry-tag-search
@Leandroqo
add isError prop to the input component
806ceed 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
add circle release tests
34336d4 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
Merge branch 'master' of https://github.com/ZupIT/charlescd into fix/…
9611ccb 
…docker-registry-tag-search
Leandroqo and others added 4 commits July 10, 2020 11:34
@Leandroqo
test invalid create release component
2bf3c73 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@adautopaulazup
Adding docker registry tag handler unit tests
a5a9ff7 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@Leandroqo
change ui workflow to yarn
da3d94f 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
Merge branch 'fix/docker-registry-tag-search' of https://github.com/Z…
3f39c95 
…upIT/charlescd into fix/docker-registry-tag-search
ifdouglas-zz
ifdouglas-zz approved these changes Jul 10, 2020
View reviewed changes
Copy link

@ifdouglas-zz ifdouglas-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI is approved.

adautopaulazup and others added 4 commits July 10, 2020 15:22
@adautopaulazup
Adding license header
ba1c795 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adautopaulazup
Merge branch 'fix/docker-registry-tag-search' of github.com:ZupIT/cha…
5ad44c4 
…rlescd into fix/docker-registry-tag-search
@Leandroqo
change isError prop to hasError
cf4239f 
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo
Merge branch 'fix/docker-registry-tag-search' of https://github.com/Z…
f54a5a3 
…upIT/charlescd into fix/docker-registry-tag-search
ifdouglas-zz
ifdouglas-zz previously approved these changes Jul 10, 2020
View reviewed changes
apucci
apucci previously approved these changes Jul 10, 2020
View reviewed changes
@adauto adauto added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 10, 2020
@adauto @adautopaulazup
Merge branch 'master' into fix/docker-registry-tag-search
b8ac247 
Signed-off-by: Adauto Afonso de Paula <adauto.paula@zup.com.br>
@adauto adauto force-pushed the fix/docker-registry-tag-search branch from c6b28eb to b8ac247 Compare July 10, 2020 19:43
@adauto adauto merged commit b3fa3a7 into master Jul 10, 2020
@adauto adauto deleted the fix/docker-registry-tag-search branch July 10, 2020 19:54
barbararochazup pushed a commit that referenced this pull request Jan 21, 2022
@adauto
Merge pull request #241 from ZupIT/fix/docker-registry-tag-search
b7bde48 
fixing docker registry component tag search
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Leandroqo Leandroqo Leandroqo left review comments

@apucci apucci apucci approved these changes

@SchumaiquerZup SchumaiquerZup SchumaiquerZup approved these changes

@jeiassoareszup jeiassoareszup jeiassoareszup approved these changes

@ifdouglas-zz ifdouglas-zz ifdouglas-zz left review comments

@washingtonsoares washingtonsoares washingtonsoares left review comments

Assignees
No one assigned
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module. villager Improvements/additions/fixes for villager module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@adauto @ifdouglas-zz @washingtonsoares @apucci @Leandroqo @SchumaiquerZup @jeiassoareszup @adautopaulazup @ricardorames