Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

User flow with external IDM #613

Merged
merged 48 commits into from
Feb 19, 2021
Merged

User flow with external IDM #613

merged 48 commits into from
Feb 19, 2021

Conversation

pedroborgeszup
Copy link
Contributor

Some features in the user flow, such as create user, reset password, change password and delete user have been blocked if using an external IDM

Signed-off-by: pedroborgeszup <pedro.borges@zup.com.br>
…ge password

Signed-off-by: pedroborgeszup <pedro.borges@zup.com.br>
@boring-cyborg boring-cyborg bot added moove Improvements/additions/fixes for moove module. ui Improvements/additions/fixes for ui module. labels Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #613 (183e135) into main (f62ae97) will increase coverage by 0.03%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #613      +/-   ##
============================================
+ Coverage     69.34%   69.37%   +0.03%     
- Complexity     1737     1741       +4     
============================================
  Files          1196     1196              
  Lines         17127    17134       +7     
  Branches       1578     1583       +5     
============================================
+ Hits          11877    11887      +10     
+ Misses         4761     4759       -2     
+ Partials        489      488       -1     
Flag Coverage Δ Complexity Δ
moove 59.37% <100.00%> (+0.07%) 0.00 <10.00> (ø)
ui 77.47% <68.42%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/providers/base/hooks.ts 83.05% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Users/hooks.ts 75.49% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/utils/auth.ts 88.70% <50.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Users/Menu/index.tsx 71.42% <50.00%> (+2.19%) 0.00 <0.00> (ø)
ui/src/modules/Users/Menu/styled.ts 81.81% <66.66%> (-7.08%) 0.00 <0.00> (ø)
...tlin/io/charlescd/moove/application/UserService.kt 100.00% <100.00%> (+4.00%) 15.00 <2.00> (ø)
...tion/user/impl/ChangeUserPasswordInteractorImpl.kt 100.00% <100.00%> (ø) 3.00 <2.00> (+1.00)
.../application/user/impl/CreateUserInteractorImpl.kt 97.05% <100.00%> (+9.18%) 10.00 <0.00> (+2.00)
...ation/user/impl/ResetUserPasswordInteractorImpl.kt 100.00% <100.00%> (ø) 8.00 <2.00> (+1.00)
...cd/moove/commons/constants/MooveErrorCodeLegacy.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62ae97...6b864a9. Read the comment docs.

Leandroqo
Leandroqo previously approved these changes Oct 19, 2020
@pedroborgeszup pedroborgeszup self-assigned this Oct 19, 2020
Leandroqo
Leandroqo previously approved these changes Oct 26, 2020
monicaribeiro
monicaribeiro previously approved these changes Oct 27, 2020
Base automatically changed from master to main January 12, 2021 13:42
@monicaribeiro
Copy link
Contributor

In test.

ifdouglas and others added 18 commits January 29, 2021 10:27
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Leandroqo and others added 3 commits February 18, 2021 14:52
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@monicaribeiro monicaribeiro merged commit 1b3c0ad into main Feb 19, 2021
@monicaribeiro monicaribeiro deleted the external-idm-user-flow branch February 19, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants