This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…ot header Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
============================================
+ Coverage 70.91% 77.14% +6.23%
- Complexity 1874 1978 +104
============================================
Files 1207 1208 +1
Lines 17612 16619 -993
Branches 1638 1524 -114
============================================
+ Hits 12489 12821 +332
+ Misses 4649 3318 -1331
- Partials 474 480 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
…charlescd into validate-resources-with-other-ids
…cd into validate-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…m/ZupIT/charlescd into validate-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
…charlescd into validate-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…date-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
Signed-off-by: e-km <eduardo.miyoshi@zup.com.br>
…te-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…m/ZupIT/charlescd into workspaces-users-endpoint
Workspaces users endpoint
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…m/ZupIT/charlescd into validate-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…m/ZupIT/charlescd into validate-resources-with-other-ids
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
circle-matcher
Improvements/additions/fixes for circle-matcher module.
moove
Improvements/additions/fixes for moove module.
security
TESTED
QA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It is possible for a non-root user with access to the consumed resource to access information / change information available only to another user, if that user has the same profile as him
Solution:
When non-root users to consume resources that have as input other ids (hypothesisId, buildId, deploymentId, etc.) to validate permission according to x-workspace-id