added percentage strategy #726

lucassaleszup · 2020-12-01T13:37:47Z

Signed-off-by: Lucas Sales lucas.sales@zup.com.br

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

codecov · 2020-12-01T13:39:18Z

Codecov Report

Merging #726 (327ae96) into main (320e997) will increase coverage by 0.40%.
The diff coverage is 85.26%.

❗ Current head 327ae96 differs from pull request most recent head 467323f. Consider uploading reports for the commit 467323f to get more accurate results

@@             Coverage Diff              @@
##               main     #726      +/-   ##
============================================
+ Coverage     77.48%   77.88%   +0.40%     
- Complexity     1978     2064      +86     
============================================
  Files          1192     1209      +17     
  Lines         16408    16854     +446     
  Branches       1493     1566      +73     
============================================
+ Hits          12713    13126     +413     
- Misses         3229     3237       +8     
- Partials        466      491      +25

Flag	Coverage Δ	Complexity Δ
circlematcher	`87.31% <81.81%> (-0.70%)`	`0.00 <44.00> (ø)`
moove	`74.41% <90.16%> (+0.34%)`	`0.00 <46.00> (ø)`
ui	`80.99% <84.40%> (+0.53%)`	`0.00 <0.00> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...matcher/api/request/CreateSegmentationRequest.java	`100.00% <ø> (ø)`	`1.00 <0.00> (ø)`
...matcher/api/request/UpdateSegmentationRequest.java	`100.00% <ø> (ø)`	`3.00 <0.00> (ø)`
.../application/circle/request/CreateCircleRequest.kt	`91.30% <ø> (ø)`	`2.00 <0.00> (ø)`
ui/src/core/assets/themes/index.ts	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
ui/src/core/components/Button/Rounded/index.tsx	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
ui/src/core/components/Form/Input/index.tsx	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
ui/src/core/components/Popover/index.tsx	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
ui/src/modules/Circles/Release/Create/index.tsx	`66.66% <ø> (ø)`	`0.00 <0.00> (ø)`
ui/src/modules/Circles/Comparation/Item/index.tsx	`53.22% <26.31%> (-5.27%)`	`0.00 <0.00> (ø)`
ui/src/modules/Circles/Release/hooks.ts	`79.06% <57.14%> (-11.26%)`	`0.00 <0.00> (ø)`
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320e997...467323f. Read the comment docs.

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

ui/src/core/assets/svg/alternate-down.svg

ui/src/core/assets/svg/manually.svg

ui/src/core/assets/svg/percentage.svg

ui/src/modules/Circles/Comparation/Item/CreateSegments/__tests__/Percentage.spec.tsx

ui/src/modules/Circles/Comparation/Item/Layer/Release.tsx

ui/src/modules/Circles/Comparation/Item/Percentage/__tests__/CirclePercentageList.spec.tsx

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Leandroqo · 2020-12-02T17:13:33Z

ui/src/core/assets/svg/alert.svg

+            <g id="Group-16" transform="translate(1098.000000, 0.000000)">
+                <g id="Icon/Arrow/Straight/Left-Copy-3" transform="translate(75.000000, 312.000000)">
+                    <mask id="mask-2" fill="white">
+                        <use xlink:href="#path-1"></use>


change path-1 to path-alert.

Leandroqo · 2020-12-02T17:15:31Z

ui/src/core/assets/svg/alert.svg

+                    <mask id="mask-2" fill="white">
+                        <use xlink:href="#path-1"></use>
+                    </mask>
+                    <use id="Icon-Alert-Triangle" fill="#FFD60A" xlink:href="#path-1"></use>


Suggested change

<use id="Icon-Alert-Triangle" fill="#FFD60A" xlink:href="#path-1"></use>

<use id="Icon-Alert-Triangle" fill="currentColor" xlink:href="#path-1"></use>

Leandroqo · 2020-12-02T17:15:58Z

ui/src/core/assets/svg/alternate-down.svg

+                <mask id="mask-2-alternate-down" fill="white">
+                    <use xlink:href="#path-1-alternate-down"></use>
+                </mask>
+                <use id="Icon-Chevron-Down" fill="#B9B9BE" xlink:href="#path-1-alternate-down"></use>


Suggested change

<use id="Icon-Chevron-Down" fill="#B9B9BE" xlink:href="#path-1-alternate-down"></use>

<use id="Icon-Chevron-Down" fill="currentColor" xlink:href="#path-1-alternate-down"></use>

Leandroqo · 2020-12-02T17:16:15Z

ui/src/core/assets/svg/manually.svg

+            <mask id="mask-2-manually" fill="white">
+                <use xlink:href="#path-1-manually"></use>
+            </mask>
+            <use id="Icon-Edit" fill="#B9B9BE" xlink:href="#path-1-manually"></use>


Suggested change

<use id="Icon-Edit" fill="#B9B9BE" xlink:href="#path-1-manually"></use>

<use id="Icon-Edit" fill="currentColor" xlink:href="#path-1-manually"></use>

Leandroqo · 2020-12-02T17:16:29Z

ui/src/core/assets/svg/percentage.svg

+                    <mask id="mask-2-percentage" fill="white">
+                        <use xlink:href="#path-1-percentage"></use>
+                    </mask>
+                    <use id="Icon-Percent" fill="#B9B9BE" xlink:href="#path-1-percentage"></use>


Suggested change

<use id="Icon-Percent" fill="#B9B9BE" xlink:href="#path-1-percentage"></use>

<use id="Icon-Percent" fill="currentColor" xlink:href="#path-1-percentage"></use>

Leandroqo · 2020-12-02T17:16:44Z

ui/src/core/assets/svg/up.svg

+                <mask id="mask-2-up" fill="white">
+                    <use xlink:href="#path-1-up"></use>
+                </mask>
+                <use id="Icon-Chevron-Up" fill="#B9B9BE" transform="translate(4.666833, 2.666750) scale(1, -1) translate(-4.666833, -2.666750) " xlink:href="#path-1-up"></use>


Suggested change

<use id="Icon-Chevron-Up" fill="#B9B9BE" transform="translate(4.666833, 2.666750) scale(1, -1) translate(-4.666833, -2.666750) " xlink:href="#path-1-up"></use>

<use id="Icon-Chevron-Up" fill="currentColor" transform="translate(4.666833, 2.666750) scale(1, -1) translate(-4.666833, -2.666750) " xlink:href="#path-1-up"></use>

Leandroqo · 2020-12-02T17:23:16Z

ui/src/modules/Circles/Comparation/Item/CreateSegments/Slider.tsx

+          placeholder="Value"
+          ref={register({
+            required: 'Percentage is required.',
+            validate: value => {


what do you think of putting this in utils?

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Signed-off-by: Thalles Freitas <thalles.freitas@zup.com.br>

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

into percentage-strategy Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

eliasalveszup · 2021-01-11T13:29:21Z

circle-matcher/src/main/java/io/charlescd/circlematcher/domain/Circle.java

@@ -36,6 +36,13 @@ public String getName() {
        return name;
    }

+    public static Circle from(KeyMetadata keyMetadata) {


Verify if argument is null/invalid and throw IllegalArgumentException if so, or it may cause a NPE.

This validation is done here with the ifPresent, it is necessary to do inside the class?

this.getCircleByPercentage(percentageMatched)
.ifPresent(keyMetadata -> matched.add(Circle.from(keyMetadata)));

The use of method is ok (null safe), but it's a good practice to avoid this kind of risk encapsulating this validation, because you cannot guarantee that everyone that will use this method has this concern.

Agreed.Done

eliasalveszup · 2021-01-11T13:32:25Z

circle-matcher/src/main/java/io/charlescd/circlematcher/domain/KeyMetadata.java

+        return this.percentage;
+    }
+
+    public void setPercentage(Integer percentage) {


This must not allow values lower than 0 and bigger than 100. This should be verified here and also throw IllegalArgumentException if so.

the validation was inserted on the request dto entity, it is necessary to add here too? also the percentage could be null on csv and regular circles.

Is it guaranteed that the use of this attribute will only be by request dto? If yes, ok. If not, the verification is a good practice (in case of not null).

It's not.Done

eliasalveszup · 2021-01-11T13:35:50Z

circle-matcher/src/main/java/io/charlescd/circlematcher/domain/KeyMetadata.java

+        this.percentage = percentage;
+    }
+
+    public int sumPercentage(Integer percentageToSum) {


The result of sum should also be verified before change the variable. Not < 0 and not > 100.

...in/kotlin/io/charlescd/moove/application/circle/request/CreateCircleWithPercentageRequest.kt

...esources/db/changelog/includes/20201007113800_alter_table_circles_add_percentage_column.yaml

emiteze

Please check my comments, i approved instead of asking for changes

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

into percentage-strategy Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

ui/src/core/components/Form/Number/helper.ts

ui/src/modules/Circles/Comparation/Item/CreateSegments/Slider.tsx

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

added percentage strategy

c9cbc17

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

boring-cyborg bot added circle-matcher Improvements/additions/fixes for circle-matcher module. moove Improvements/additions/fixes for moove module. labels Dec 1, 2020

added warnings and validations

0367b1c

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

ifdouglas suggested changes Dec 1, 2020

View reviewed changes

requested changes

368fd50

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Leandroqo suggested changes Dec 2, 2020

View reviewed changes

requested changes and remove lint extra line

d3b4c1b

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

Leandroqo previously approved these changes Dec 2, 2020

View reviewed changes

fix conflicts

edd4ec6

Signed-off-by: Thalles Freitas <thalles.freitas@zup.com.br>

thallesfreitaszup dismissed Leandroqo’s stale review via edd4ec6 December 7, 2020 00:36

thallesfreitaszup and others added 2 commits December 8, 2020 09:15

Merge branch 'master' into percentage-strategy

ce9fe1f

merge with master

128f884

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label Dec 15, 2020

Merge branch 'master' into percentage-strategy

b7cc95d

bCatanant previously approved these changes Dec 15, 2020

View reviewed changes

thallesfreitaszup added 3 commits January 4, 2021 15:53

first fix conflicts

ad834d5

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

first change conflicts

f496537

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

fix tests

b55ec39

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

thallesfreitaszup dismissed bCatanant’s stale review via b55ec39 January 5, 2021 05:43

fix conflicts and props

6ee80e2

Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>

ifdouglas previously approved these changes Jan 5, 2021

View reviewed changes

thallesfreitaszup added 2 commits January 7, 2021 16:07

fix conflicts

05801e7

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

Merge branch 'percentage-strategy' of https://github.com/ZupIT/charlescd

8d5af1a

into percentage-strategy Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

thallesfreitaszup dismissed ifdouglas’s stale review via 8d5af1a January 7, 2021 19:08

Merge branch 'master' into percentage-strategy

4445fe0

eliasalveszup reviewed Jan 11, 2021

View reviewed changes

emiteze approved these changes Mar 11, 2021

View reviewed changes

...in/kotlin/io/charlescd/moove/application/circle/request/CreateCircleWithPercentageRequest.kt Show resolved Hide resolved

...esources/db/changelog/includes/20201007113800_alter_table_circles_add_percentage_column.yaml Outdated Show resolved Hide resolved

emiteze suggested changes Mar 11, 2021

View reviewed changes

ifdouglas and others added 3 commits March 12, 2021 09:32

test improvements

a48c00d

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

requested changes

7c59c76

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

Merge branch 'percentage-strategy' of https://github.com/ZupIT/charlescd

bcdecae

into percentage-strategy Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

thallesfreitaszup dismissed stale reviews from eliasalveszup, bCatanant, and Leandroqo via bcdecae March 12, 2021 12:38

fix typo

fddd6ed

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

thallesfreitaszup requested review from emiteze and eliasalveszup March 12, 2021 12:48

ifdouglas added 3 commits March 16, 2021 14:25

force only numbers

7abee82

adding error handler

d616f6b

Merge branch 'main' into percentage-strategy

8f62150

bCatanant reviewed Mar 16, 2021

View reviewed changes

ui/src/core/components/Form/Number/helper.ts Show resolved Hide resolved

ui/src/modules/Circles/Comparation/Item/CreateSegments/Slider.tsx Show resolved Hide resolved

add certificate

327ae96

bCatanant previously approved these changes Mar 16, 2021

View reviewed changes

eliasalveszup previously approved these changes Mar 16, 2021

View reviewed changes

emiteze previously approved these changes Mar 16, 2021

View reviewed changes

angelicalimazup added the TESTED QA label Mar 16, 2021

fix conflict

4108ed9

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>

thallesfreitaszup dismissed stale reviews from emiteze, eliasalveszup, and bCatanant via 4108ed9 March 16, 2021 20:09

bCatanant approved these changes Mar 16, 2021

View reviewed changes

angelicalimazup self-requested a review March 16, 2021 20:41

angelicalimazup approved these changes Mar 16, 2021

View reviewed changes

Merge branch 'main' into percentage-strategy

467323f

angelicalimazup merged commit ca12571 into main Mar 17, 2021

angelicalimazup deleted the percentage-strategy branch March 17, 2021 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added percentage strategy #726

added percentage strategy #726

lucassaleszup commented Dec 1, 2020

codecov bot commented Dec 1, 2020 •

edited

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

Leandroqo Dec 2, 2020

eliasalveszup Jan 11, 2021 •

edited

thallesfreitaszup Jan 14, 2021

eliasalveszup Jan 14, 2021

thallesfreitaszup Jan 14, 2021

eliasalveszup Jan 11, 2021

thallesfreitaszup Jan 14, 2021 •

edited

eliasalveszup Jan 14, 2021

thallesfreitaszup Jan 14, 2021

eliasalveszup Jan 11, 2021

thallesfreitaszup Jan 14, 2021

emiteze left a comment

	<use id="Icon-Alert-Triangle" fill="#FFD60A" xlink:href="#path-1"></use>
	<use id="Icon-Alert-Triangle" fill="currentColor" xlink:href="#path-1"></use>

	<use id="Icon-Chevron-Down" fill="#B9B9BE" xlink:href="#path-1-alternate-down"></use>
	<use id="Icon-Chevron-Down" fill="currentColor" xlink:href="#path-1-alternate-down"></use>

	<use id="Icon-Edit" fill="#B9B9BE" xlink:href="#path-1-manually"></use>
	<use id="Icon-Edit" fill="currentColor" xlink:href="#path-1-manually"></use>

	<use id="Icon-Percent" fill="#B9B9BE" xlink:href="#path-1-percentage"></use>
	<use id="Icon-Percent" fill="currentColor" xlink:href="#path-1-percentage"></use>

	<use id="Icon-Chevron-Up" fill="#B9B9BE" transform="translate(4.666833, 2.666750) scale(1, -1) translate(-4.666833, -2.666750) " xlink:href="#path-1-up"></use>
	<use id="Icon-Chevron-Up" fill="currentColor" transform="translate(4.666833, 2.666750) scale(1, -1) translate(-4.666833, -2.666750) " xlink:href="#path-1-up"></use>

added percentage strategy #726

added percentage strategy #726

Conversation

lucassaleszup commented Dec 1, 2020

codecov bot commented Dec 1, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eliasalveszup Jan 11, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thallesfreitaszup Jan 14, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emiteze left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 1, 2020 •

edited

eliasalveszup Jan 11, 2021 •

edited

thallesfreitaszup Jan 14, 2021 •

edited