This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Added new validation in the createModuleRequest #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>
boring-cyborg
bot
added
the
butler
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
=========================================
Coverage 69.25% 69.25%
Complexity 1736 1736
=========================================
Files 1196 1197 +1
Lines 17068 17077 +9
Branches 1570 1571 +1
=========================================
+ Hits 11820 11827 +7
- Misses 4760 4762 +2
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>
Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>
leandrorodrigueszup
previously approved these changes
Jan 11, 2021
Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>
thallesfreitaszup
previously approved these changes
Feb 8, 2021
lucasbfernandes
suggested changes
Feb 9, 2021
| if (components && components.length) { | ||
| return true | ||
| } else { | ||
| throw new HttpException({ error: 'Bad Request', message:['components could not be null or empty'], statusCode: HttpStatus.BAD_REQUEST }, HttpStatus.BAD_REQUEST) |
There was a problem hiding this comment.
Change to "components should not be null or empty"
Signed-off-by: Lucas Sales <lucas.sales@zup.com.br>
lucasbfernandes
previously approved these changes
Feb 11, 2021
thallesfreitaszup
previously approved these changes
Feb 11, 2021
lucassaleszup
dismissed stale reviews from thallesfreitaszup and lucasbfernandes
via
7e950ce
lucasbfernandes
approved these changes
Feb 11, 2021
thallesfreitaszup
approved these changes
Feb 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucas Sales lucas.sales@zup.com.br