This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
boring-cyborg
bot
added
the
butler
Improvements/additions/fixes for butler module.
label
Jan 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #810 +/- ##
============================================
+ Coverage 77.84% 77.86% +0.01%
Complexity 2064 2064
============================================
Files 1209 1209
Lines 16857 16868 +11
Branches 1568 1575 +7
============================================
+ Hits 13123 13134 +11
Misses 3249 3249
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cpgo
previously approved these changes
Feb 12, 2021
lucasbfernandes
previously approved these changes
Feb 23, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
thallesfreitaszup
dismissed stale reviews from lucasbfernandes and cpgo
via
February 24, 2021 18:34
e6ffb57
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
boring-cyborg
bot
added
the
octopipe
Improvements/additions/fixes for octopipe module.
label
Feb 25, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
lucasbfernandes
previously approved these changes
Mar 4, 2021
cpgo
previously approved these changes
Mar 4, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
thallesfreitaszup
dismissed stale reviews from cpgo and lucasbfernandes
via
March 10, 2021 18:58
d1766f2
lucasbfernandes
approved these changes
Mar 12, 2021
cpgo
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Undeploy pipeline in octopipe and spinnaker had the destination rules being undeployed before the virtual service, what could cause a 503 status because the virtual service route could have a subset that already have being removed in the moment of undeploy
Solution
undeploy of virtual service before the undeploy of destination rules