Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Change butler steps on pipeline #810

Merged
merged 13 commits into from
Mar 17, 2021
Merged

Change butler steps on pipeline #810

merged 13 commits into from
Mar 17, 2021

Conversation

thallesfreitaszup
Copy link
Contributor

@thallesfreitaszup thallesfreitaszup commented Jan 15, 2021

Issue

Undeploy pipeline in octopipe and spinnaker had the destination rules being undeployed before the virtual service, what could cause a 503 status because the virtual service route could have a subset that already have being removed in the moment of undeploy

Solution

undeploy of virtual service before the undeploy of destination rules

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #810 (251cb69) into main (ca12571) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #810      +/-   ##
============================================
+ Coverage     77.84%   77.86%   +0.01%     
  Complexity     2064     2064              
============================================
  Files          1209     1209              
  Lines         16857    16868      +11     
  Branches       1568     1575       +7     
============================================
+ Hits          13123    13134      +11     
  Misses         3249     3249              
  Partials        485      485              
Flag Coverage Δ Complexity Δ
butler 85.75% <100.00%> (+0.11%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...er/templates/deployment/destination-rules-stage.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...p/v2/core/integrations/octopipe/request-builder.ts 89.41% <100.00%> (ø) 0.00 <0.00> (ø)
...v2/core/integrations/spinnaker/pipeline-builder.ts 91.40% <100.00%> (ø) 0.00 <0.00> (ø)
...s/undeployment/undeploy-destination-rules-stage.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...eployment/undeploy-empty-virtual-services-stage.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...es/undeployment/undeploy-proxy-evaluation-stage.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...es/undeployment/undeploy-virtual-services-stage.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...loyments/use-cases/paginated-executions.usecase.ts 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca12571...251cb69. Read the comment docs.

cpgo
cpgo previously approved these changes Feb 12, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
 into change-butler-steps

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the octopipe Improvements/additions/fixes for octopipe module. label Feb 25, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
lucasbfernandes
lucasbfernandes previously approved these changes Mar 4, 2021
cpgo
cpgo previously approved these changes Mar 4, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@eliasalveszup eliasalveszup merged commit fa58178 into main Mar 17, 2021
@eliasalveszup eliasalveszup deleted the change-butler-steps branch March 17, 2021 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module. octopipe Improvements/additions/fixes for octopipe module. TESTED QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants