Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Users: Pagination and infinite scroll #824

Merged
merged 53 commits into from
Feb 18, 2021
Merged

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Jan 21, 2021

Frontend

  • Include infinite scroll to users

Backend

  • Add max page length at users endpoint

luanecavalcantizup and others added 3 commits January 15, 2021 16:09
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Mônica Ribeiro <monicarib1@gmail.com>
@boring-cyborg boring-cyborg bot added moove Improvements/additions/fixes for moove module. ui Improvements/additions/fixes for ui module. labels Jan 21, 2021
luanecavalcantizup and others added 17 commits January 21, 2021 16:49
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #824 (5f1d8ec) into main (48ff8b5) will increase coverage by 0.18%.
The diff coverage is 87.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #824      +/-   ##
============================================
+ Coverage     69.29%   69.48%   +0.18%     
  Complexity     1737     1737              
============================================
  Files          1196     1198       +2     
  Lines         17098    17115      +17     
  Branches       1574     1575       +1     
============================================
+ Hits          11848    11892      +44     
+ Misses         4762     4734      -28     
- Partials        488      489       +1     
Flag Coverage Δ Complexity Δ
moove 59.30% <ø> (ø) 0.00 <ø> (ø)
ui 77.79% <87.17%> (+0.41%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Account/Menu/MenuItem.tsx 83.33% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Hypotheses/Menu/MenuItem.tsx 16.66% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Metrics/Menu/MenuItem.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/MenuItem.tsx 60.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Settings/Menu/MenuItem.tsx 83.33% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/Menu/MenuItem.tsx 92.30% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Users/Menu/index.tsx 75.00% <50.00%> (+5.76%) 0.00 <0.00> (ø)
ui/src/modules/Users/index.tsx 80.76% <72.72%> (+64.97%) 0.00 <0.00> (ø)
ui/src/modules/Users/Menu/MenuItem.tsx 87.50% <87.50%> (-12.50%) 0.00 <0.00> (ø)
ui/src/core/components/LabeledIcon/index.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ff8b5...68e86d9. Read the comment docs.

@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review February 1, 2021 18:53
@luanecavalcantizup luanecavalcantizup marked this pull request as draft February 2, 2021 19:02
@monicaribeiro monicaribeiro marked this pull request as ready for review February 8, 2021 13:25
monicaribeiro
monicaribeiro previously approved these changes Feb 9, 2021
monicaribeirozup and others added 3 commits February 9, 2021 15:36
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
…fix/users-pagination

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@monicaribeiro monicaribeiro merged commit e9148c1 into main Feb 18, 2021
@monicaribeiro monicaribeiro deleted the fix/users-pagination branch February 18, 2021 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants