This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
…utes Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
boring-cyborg
bot
added
butler
Improvements/additions/fixes for butler module.
octopipe
Improvements/additions/fixes for octopipe module.
labels
Jan 27, 2021
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
============================================
+ Coverage 69.48% 69.53% +0.04%
Complexity 1741 1741
============================================
Files 1199 1199
Lines 17309 17346 +37
Branches 1606 1618 +12
============================================
+ Hits 12028 12062 +34
- Misses 4796 4799 +3
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
TODO: put orderBy clause on findActiveComponents Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
eliasalveszup
requested review from
thallesfreitaszup and
leandrorodrigueszup
January 27, 2021 14:28
@@ -288,4 +289,268 @@ describe('V2 Octopipe Deployment Request Builder', () => { | |||
).toEqual(completeOctopipeDeploymentWithOverrides) | |||
}) | |||
|
|||
it('Should undeploy A:v1 and B:v1 and C:v2 when new deploy is A:v2, B:V2 and D:v2 and current components are A:v1, B:V1 and C:v2, but should keep remove C:V2 from circle-id', async() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is a little confused! Maybe it could describe in a more functional way what is happening!
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
thallesfreitaszup
previously approved these changes
Feb 3, 2021
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
lucasbfernandes
previously approved these changes
Feb 4, 2021
leandrorodrigueszup
previously approved these changes
Feb 5, 2021
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
cpgo
dismissed stale reviews from leandrorodrigueszup and lucasbfernandes
via
February 19, 2021 16:35
300b8ec
lucasbfernandes
approved these changes
Feb 22, 2021
fandrade-zup
approved these changes
Feb 22, 2021
leandrorodrigueszup
approved these changes
Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds steps on spinnaker and octopipe pipeline to cleanup the virtualservices and destination rules.
Given the following state of the cluster
And the user deploys the following components
We have to
1 - Remove deployments and services of
component2:v1
from thesome-circle
circle2 - Remove virtual services and destination rules of
component2:v1
from thesome-circle
circle3 - Keep
component2:v1
on thedefault-circle
untouched