Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improve error details #832

Merged
merged 53 commits into from
Feb 25, 2021
Merged

Improve error details #832

merged 53 commits into from
Feb 25, 2021

Conversation

thallesfreitaszup
Copy link
Contributor

No description provided.

@thallesfreitaszup
add structured error response
a678974 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
add changes moove
36e5f82 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
add moove changes
c31b679 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix error
ded6a52 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix config decoder
e3598de 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
log response
77e705e 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
debug
2bd94e4 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
test
881a22d 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'main' of https://github.com/ZupIT/charlescd into releas…
8d1863e 
…e-darwin-imp-4

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
improvements on error details
8bd1a8a 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added circle-matcher Improvements/additions/fixes for circle-matcher module. moove Improvements/additions/fixes for moove module. labels Jan 27, 2021
@thallesfreitaszup thallesfreitaszup marked this pull request as draft January 27, 2021 13:31
@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited

Codecov Report

Merging #832 (bd457ac) into main (a6819b5) will increase coverage by 0.15%.
The diff coverage is 77.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #832      +/-   ##
============================================
+ Coverage     70.75%   70.91%   +0.15%     
- Complexity     1841     1874      +33     
============================================
  Files          1204     1207       +3     
  Lines         17485    17612     +127     
  Branches       1632     1638       +6     
============================================
+ Hits          12371    12489     +118     
- Misses         4645     4649       +4     
- Partials        469      474       +5
Flag Coverage Δ Complexity Δ
circlematcher 88.01% <77.38%> (+2.09%) 0.00 <24.00> (ø)
moove 59.67% <76.56%> (+0.16%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...arlescd/moove/application/ErrorDetailedResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cd/circlematcher/handler/DefaultErrorResponse.java 53.33% <57.14%> (+53.33%) 8.00 <8.00> (+8.00)
...clematcher/domain/exception/BusinessException.java 70.00% <68.42%> (-5.00%) 6.00 <5.00> (+5.00) ⬇️
...cture/configuration/MatcherEncoderConfiguration.kt 87.50% <87.50%> (ø) 0.00 <0.00> (?)
...harlescd/circlematcher/handler/ExceptionUtils.java 92.30% <92.30%> (ø) 6.00 <6.00> (?)
...rclematcher/domain/exception/MatcherErrorCode.java 81.81% <100.00%> (+15.15%) 4.00 <2.00> (+2.00)
...r/domain/service/impl/SegmentationServiceImpl.java 100.00% <100.00%> (ø) 27.00 <0.00> (ø)
.../charlescd/circlematcher/handler/ErrorHandler.java 100.00% <100.00%> (+100.00%) 12.00 <3.00> (+12.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6819b5...57302ad. Read the comment docs.

thallesfreitaszup and others added 16 commits January 27, 2021 11:20
@thallesfreitaszup
add tests
74e841c 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix test
c345d45 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
add more coverage
f830102 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'main' into improve-error-details
65e2cd0
@thallesfreitaszup
Merge branch 'main' into improve-error-details
8766d61
@thallesfreitaszup
error handler
6874adc 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'improve-error-details' of https://github.com/ZupIT/char…
4d1238c 
…lescd into improve-error-details

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'main' into improve-error-details
2362e88
@thallesfreitaszup
fix checkstyle
6c90998 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
message error
00274a4 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'improve-error-details' of https://github.com/ZupIT/char…
4544ddc 
…lescd into improve-error-details

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'main' into improve-error-details
273522d
@thallesfreitaszup
fix test
dcd1fca 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'improve-error-details' of https://github.com/ZupIT/char…
cc34a39 
…lescd into improve-error-details

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix test
3b8827f 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix checkstyle
6e8b7ac 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
eliasalveszup
eliasalveszup reviewed Feb 9, 2021
View reviewed changes
circle-matcher/src/main/java/io/charlescd/circlematcher/handler/ExceptionUtils.java Outdated
String message,
String title,
String sourceString,
Exception exception) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception parameter is not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.Thanks!

@thallesfreitaszup
pr suggestions
dc4a1b4 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'improve-error-details' of https://github.com/ZupIT/char…
005cac6 
…lescd into improve-error-details

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
Merge branch 'main' of https://github.com/ZupIT/charlescd into improv…
000ad03 
…e-error-details

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup
fix checkstyle
cc14662 
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
eliasalveszup
eliasalveszup previously approved these changes Feb 12, 2021
View reviewed changes
cpgo
cpgo previously approved these changes Feb 23, 2021
View reviewed changes
@angelicalimazup angelicalimazup added TESTED QA and removed TESTED QA labels Feb 23, 2021
@thallesfreitaszup thallesfreitaszup merged commit b415d38 into main Feb 25, 2021
@thallesfreitaszup thallesfreitaszup deleted the improve-error-details branch February 25, 2021 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucasbfernandes lucasbfernandes lucasbfernandes approved these changes

@eliasalveszup eliasalveszup eliasalveszup approved these changes

@cpgo cpgo cpgo left review comments

Assignees
No one assigned
Labels
circle-matcher Improvements/additions/fixes for circle-matcher module. moove Improvements/additions/fixes for moove module. TESTED QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thallesfreitaszup @cpgo @lucasbfernandes @eliasalveszup @angelicalimazup