Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Adding pagination for User Groups menu items #851

Merged
merged 21 commits into from
Feb 9, 2021

Conversation

ifdouglas
Copy link
Contributor

@ifdouglas ifdouglas commented Jan 29, 2021

Adding pagination for User Groups menu items to prevent memory depletion

@ifdouglas ifdouglas added ui Improvements/additions/fixes for ui module. moove Improvements/additions/fixes for moove module. labels Jan 29, 2021
@ifdouglas ifdouglas self-assigned this Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #851 (069e781) into main (a1b2729) will increase coverage by 0.04%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #851      +/-   ##
============================================
+ Coverage     69.25%   69.29%   +0.04%     
  Complexity     1736     1736              
============================================
  Files          1196     1196              
  Lines         17068    17097      +29     
  Branches       1570     1574       +4     
============================================
+ Hits          11820    11847      +27     
- Misses         4760     4762       +2     
  Partials        488      488              
Flag Coverage Δ Complexity Δ
moove 59.29% <ø> (ø) 0.00 <ø> (ø)
ui 77.38% <95.65%> (+0.06%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Groups/Menu/Loaders/list.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Menu/MenuItem.tsx 66.66% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/index.tsx 94.11% <ø> (-1.34%) 0.00 <0.00> (ø)
ui/src/core/providers/user-group.ts 85.00% <50.00%> (-3.89%) 0.00 <0.00> (ø)
ui/src/modules/Groups/Menu/index.tsx 95.83% <95.65%> (-4.17%) 0.00 <0.00> (ø)
ui/src/modules/Groups/Menu/styled.ts 85.71% <100.00%> (+1.09%) 0.00 <0.00> (ø)
ui/src/modules/Groups/helpers.ts 55.00% <100.00%> (+5.00%) 0.00 <0.00> (ø)
ui/src/modules/Groups/hooks.ts 90.00% <100.00%> (+0.97%) 0.00 <0.00> (ø)
ui/src/modules/Groups/state/actions.ts 80.00% <100.00%> (+5.00%) 0.00 <0.00> (ø)
ui/src/modules/Groups/state/reducer.ts 70.00% <100.00%> (+7.50%) 0.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d964040...db38d5d. Read the comment docs.

@ifdouglas ifdouglas marked this pull request as ready for review February 1, 2021 19:26
Leandroqo
Leandroqo previously approved these changes Feb 2, 2021
Leandroqo
Leandroqo previously approved these changes Feb 3, 2021
Leandroqo
Leandroqo previously approved these changes Feb 5, 2021
@monicaribeiro monicaribeiro merged commit a17d7f4 into main Feb 9, 2021
@monicaribeiro monicaribeiro deleted the issue/user-group-pagination branch February 9, 2021 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants