Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add pagination to Modules menu #864

Merged
merged 20 commits into from
Feb 11, 2021
Merged

Conversation

ifdouglas
Copy link
Contributor

Add pagination to Modules menu items to prevent memory depletion

@ifdouglas ifdouglas added the ui Improvements/additions/fixes for ui module. label Feb 2, 2021
@ifdouglas ifdouglas self-assigned this Feb 2, 2021
@ifdouglas ifdouglas added the enhancement New feature or request label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #864 (b14cec4) into main (155f565) will increase coverage by 0.04%.
The diff coverage is 82.60%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #864      +/-   ##
============================================
+ Coverage     69.25%   69.30%   +0.04%     
  Complexity     1736     1736              
============================================
  Files          1196     1196              
  Lines         17068    17092      +24     
  Branches       1570     1574       +4     
============================================
+ Hits          11820    11845      +25     
+ Misses         4760     4759       -1     
  Partials        488      488              
Flag Coverage Δ Complexity Δ
moove 59.29% <ø> (ø) 0.00 <ø> (ø)
ui 77.40% <82.60%> (+0.08%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Modules/Comparation/styled.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/Loaders/list.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/hooks/module.ts 62.16% <44.44%> (-2.55%) 0.00 <0.00> (ø)
ui/src/modules/Modules/index.tsx 75.00% <50.00%> (+37.50%) 0.00 <0.00> (ø)
ui/src/core/providers/modules.ts 68.18% <85.71%> (+3.18%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/index.tsx 89.28% <95.65%> (+12.36%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/styled.ts 86.66% <100.00%> (+2.05%) 0.00 <0.00> (ø)
ui/src/modules/Modules/state/actions.ts 85.71% <100.00%> (+2.38%) 0.00 <0.00> (ø)
ui/src/modules/Modules/state/reducer.ts 58.33% <100.00%> (+8.33%) 0.00 <0.00> (ø)
ui/src/core/components/InfiniteScroll/styled.ts 100.00% <0.00%> (+33.33%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155f565...a8314d7. Read the comment docs.

@ifdouglas ifdouglas marked this pull request as ready for review February 3, 2021 12:28
Leandroqo
Leandroqo previously approved these changes Feb 3, 2021
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Feb 3, 2021
Leandroqo
Leandroqo previously approved these changes Feb 3, 2021
monicaribeiro
monicaribeiro previously approved these changes Feb 5, 2021
@monicaribeiro monicaribeiro merged commit f62ae97 into main Feb 11, 2021
@monicaribeiro monicaribeiro deleted the feature/modules-pagination branch February 11, 2021 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants