Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix workspace list in external IDM flow #873

Merged
merged 10 commits into from
Feb 3, 2021
Merged

Conversation

ifdouglas
Copy link
Contributor

@ifdouglas ifdouglas commented Feb 3, 2021

Issues

  • When external IDM is enabled and login with a no root user, the workspace API was not called.
  • When external IDM is disabled and login with a root user, the workspace API was called twice.

Solution

Add isIDMAuthFlow condition to prevent duplicated called to workspace API and to proceed the flow when external IDM is enabled.

@ifdouglas ifdouglas added bug Something isn't working ui Improvements/additions/fixes for ui module. labels Feb 3, 2021
@ifdouglas ifdouglas self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #873 (c6b4444) into main (f93874a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
- Coverage     69.25%   69.24%   -0.02%     
  Complexity     1736     1736              
============================================
  Files          1196     1196              
  Lines         17059    17064       +5     
  Branches       1568     1569       +1     
============================================
+ Hits          11815    11816       +1     
- Misses         4756     4760       +4     
  Partials        488      488              
Flag Coverage Δ Complexity Δ
ui 77.30% <100.00%> (-0.04%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Workspaces/index.tsx 90.00% <100.00%> (-3.34%) 0.00 <0.00> (ø)
ui/src/core/providers/workspace.ts 72.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
ui/src/modules/Workspaces/hooks.ts 73.68% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93874a...c6b4444. Read the comment docs.

@monicaribeiro monicaribeiro merged commit 49ae321 into main Feb 3, 2021
@monicaribeiro monicaribeiro deleted the issue/idm-workspaces branch February 3, 2021 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants