Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix search workspaces by name #882

Merged
merged 15 commits into from
Feb 18, 2021
Merged

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Feb 4, 2021

Problem: A user could not search an existing workspace by name in the search field.

Solution: Add useEffect to trigger a call to function that filter workspaces by name.

Signed-off-by: luanecavalcantizup luane.cavalcanti@zup.com.br

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Feb 4, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this Feb 4, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #882 (a6ff0dc) into main (f62ae97) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #882      +/-   ##
============================================
+ Coverage     69.34%   69.37%   +0.03%     
  Complexity     1737     1737              
============================================
  Files          1196     1197       +1     
  Lines         17127    17132       +5     
  Branches       1578     1580       +2     
============================================
+ Hits          11877    11886       +9     
+ Misses         4761     4757       -4     
  Partials        489      489              
Flag Coverage Δ Complexity Δ
ui 77.54% <100.00%> (+0.06%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/providers/workspace.ts 84.21% <100.00%> (+11.98%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/__tests__/fixtures.ts 100.00% <100.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Workspaces/index.tsx 95.83% <100.00%> (+5.35%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/hooks.ts 78.94% <0.00%> (+5.26%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62ae97...6811c98. Read the comment docs.

luanecavalcantizup and others added 6 commits February 8, 2021 08:47
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review February 9, 2021 18:30
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@monicaribeiro monicaribeiro merged commit 07660f8 into main Feb 18, 2021
@monicaribeiro monicaribeiro deleted the fix-workspaces-search-filter-by-name branch February 18, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants