Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Deployments pagination: adding max page length. #892

Merged
merged 9 commits into from
Feb 12, 2021

Conversation

monicaribeiro
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Feb 8, 2021
@monicaribeiro monicaribeiro changed the title Deployments pagination: ddding max page length. Deployments pagination: adding max page length. Feb 8, 2021
barbararochazup
barbararochazup previously approved these changes Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #892 (1aa84c3) into main (48ff8b5) will increase coverage by 0.05%.
The diff coverage is 87.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #892      +/-   ##
============================================
+ Coverage     69.29%   69.35%   +0.05%     
  Complexity     1737     1737              
============================================
  Files          1196     1196              
  Lines         17098    17130      +32     
  Branches       1574     1578       +4     
============================================
+ Hits          11848    11880      +32     
+ Misses         4762     4761       -1     
- Partials        488      489       +1     
Flag Coverage Δ Complexity Δ
moove 59.30% <ø> (ø) 0.00 <ø> (ø)
ui 77.48% <87.69%> (+0.09%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Groups/Tabs/Modal/styled.ts 96.29% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/styled.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/Loaders/list.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/index.tsx 90.47% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/hooks/module.ts 62.16% <44.44%> (-2.55%) 0.00 <0.00> (ø)
ui/src/modules/Modules/index.tsx 75.00% <50.00%> (+37.50%) 0.00 <0.00> (ø)
ui/src/core/providers/modules.ts 68.18% <85.71%> (+3.18%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Menu/index.tsx 89.28% <95.65%> (+12.36%) 0.00 <0.00> (ø)
ui/src/core/providers/metrics.ts 88.88% <100.00%> (+2.22%) 0.00 <0.00> (ø)
ui/src/modules/Groups/Tabs/Modal/index.tsx 94.87% <100.00%> (+0.93%) 0.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ff8b5...965de89. Read the comment docs.

pedroborgeszup
pedroborgeszup previously approved these changes Feb 8, 2021
Signed-off-by: Mônica Ribeiro <monicarib1@gmail.com>
…/charlescd into enhancement/pagination-deployments
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Feb 11, 2021
@monicaribeiro monicaribeiro merged commit 299d414 into main Feb 12, 2021
@monicaribeiro monicaribeiro deleted the enhancement/pagination-deployments branch February 12, 2021 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants