Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

User Group modal multi-selection lost the selection after a search #900

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

ifdouglas
Copy link
Contributor

@ifdouglas ifdouglas commented Feb 10, 2021

Resolution

  • Listen the list of changed users before re-render the items.
  • Remove cursor: pointer to avoid incorrect click outside the Update Button.

@ifdouglas ifdouglas added bug Something isn't working ui Improvements/additions/fixes for ui module. labels Feb 10, 2021
@ifdouglas ifdouglas self-assigned this Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #900 (0352210) into main (48ff8b5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #900      +/-   ##
============================================
+ Coverage     69.29%   69.30%   +0.01%     
  Complexity     1737     1737              
============================================
  Files          1196     1196              
  Lines         17098    17104       +6     
  Branches       1574     1575       +1     
============================================
+ Hits          11848    11854       +6     
  Misses         4762     4762              
  Partials        488      488              
Flag Coverage Δ Complexity Δ
ui 77.40% <100.00%> (+0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Groups/Tabs/Modal/styled.ts 96.29% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Tabs/Modal/index.tsx 94.87% <100.00%> (+0.93%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ff8b5...0352210. Read the comment docs.

@ifdouglas ifdouglas merged commit 9ec2d6b into main Feb 11, 2021
@ifdouglas ifdouglas deleted the issue/user-group-multiselect branch February 11, 2021 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants