Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Remove microfrontend #902

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Remove microfrontend #902

merged 5 commits into from
Mar 1, 2021

Conversation

Leandroqo
Copy link
Contributor

Remove microfrontend from charlescd-ui

Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@Leandroqo Leandroqo added ui Improvements/additions/fixes for ui module. javascript Pull requests that update Javascript code labels Feb 11, 2021
@Leandroqo Leandroqo self-assigned this Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #902 (b71c111) into main (a32b2c0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #902      +/-   ##
============================================
+ Coverage     77.13%   77.14%   +0.01%     
  Complexity     1978     1978              
============================================
  Files          1209     1207       -2     
  Lines         16627    16610      -17     
  Branches       1524     1520       -4     
============================================
- Hits          12825    12814      -11     
+ Misses         3320     3314       -6     
  Partials        482      482              
Flag Coverage Δ Complexity Δ
ui 79.61% <ø> (+0.03%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/App.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/Routes.tsx 86.04% <ø> (-0.32%) 0.00 <0.00> (ø)
ui/src/core/components/Page/styled.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/utils/auth.ts 88.52% <ø> (-0.19%) 0.00 <0.00> (ø)
ui/src/modules/Main/Sidebar/index.tsx 69.69% <ø> (-0.90%) 0.00 <0.00> (ø)
ui/src/modules/Main/styled.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef08f12...60b1eeb. Read the comment docs.

ifdouglas
ifdouglas previously approved these changes Feb 11, 2021
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@monicaribeiro monicaribeiro merged commit eab0c32 into main Mar 1, 2021
@monicaribeiro monicaribeiro deleted the remove-microfrontend branch March 1, 2021 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants