Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Remove totalPages from executions response #914

Merged
merged 8 commits into from
Feb 19, 2021

Conversation

leandrorodrigueszup
Copy link
Contributor

Signed-off-by: Leandro Rodrigues leandro.rodrigues@zup.com.br

Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #914 (5513663) into main (75a50bc) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #914      +/-   ##
============================================
- Coverage     69.84%   69.48%   -0.36%     
  Complexity     1741     1741              
============================================
  Files          1224     1199      -25     
  Lines         18533    17309    -1224     
  Branches       1606     1606              
============================================
- Hits          12944    12028     -916     
+ Misses         5040     4796     -244     
+ Partials        549      485      -64     
Flag Coverage Δ Complexity Δ
butler 85.47% <100.00%> (ø) 0.00 <0.00> (ø)
compass ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...loyments/use-cases/paginated-executions.usecase.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
compass/internal/health/queries.go
compass/internal/action/main.go
compass/internal/metricsgroup/main.go
compass/internal/metricsgroup/metricsgroup.go
compass/internal/plugin/main.go
compass/internal/action/action.go
compass/internal/metric/main.go
compass/internal/action/queries.go
compass/internal/health/health.go
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a50bc...5513663. Read the comment docs.

@eliasalveszup eliasalveszup merged commit 01dfe6b into main Feb 19, 2021
@eliasalveszup eliasalveszup deleted the butler-remove-total-pages branch February 19, 2021 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module. TESTED QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants