Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[UserGroups] Prevent duplicate list after updates #918

Merged
merged 23 commits into from
Mar 9, 2021

Conversation

ifdouglas
Copy link
Contributor

No description provided.

@ifdouglas ifdouglas added bug Something isn't working ui Improvements/additions/fixes for ui module. labels Feb 19, 2021
@ifdouglas ifdouglas self-assigned this Feb 19, 2021
bCatanant
bCatanant previously approved these changes Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #918 (4d6b871) into main (540995d) will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #918      +/-   ##
============================================
+ Coverage     77.48%   77.50%   +0.02%     
  Complexity     1978     1978              
============================================
  Files          1192     1192              
  Lines         16395    16402       +7     
  Branches       1489     1490       +1     
============================================
+ Hits          12703    12713      +10     
+ Misses         3220     3217       -3     
  Partials        472      472              
Flag Coverage Δ Complexity Δ
ui 80.52% <93.75%> (+0.05%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Groups/Menu/__tests__/fixtures.ts 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Tabs/Tab.tsx 2.85% <ø> (+0.15%) 0.00 <0.00> (ø)
ui/src/modules/Groups/Menu/index.tsx 95.83% <100.00%> (ø) 0.00 <0.00> (ø)
...src/modules/Groups/Tabs/Form/__tests__/fixtures.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Groups/Tabs/Form/index.tsx 92.85% <100.00%> (+7.14%) 0.00 <0.00> (ø)
ui/src/modules/Groups/hooks.ts 90.21% <100.00%> (+0.21%) 0.00 <0.00> (ø)
ui/src/modules/Groups/state/actions.ts 85.71% <100.00%> (+5.71%) 0.00 <0.00> (ø)
ui/src/modules/Groups/state/reducer.ts 80.00% <100.00%> (+10.00%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540995d...4d6b871. Read the comment docs.

bCatanant
bCatanant previously approved these changes Feb 26, 2021
expect(userGroupForm).toBeInTheDocument();
expect(inputName).toBeInTheDocument();

act(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@ifdouglas ifdouglas Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but I realized that this issue (in this specific form) was happening because we were using onChange mode on react-hook-form and we didn't need this here, so I changed to onBlur mode and removed the acts from this tests.

@ifdouglas ifdouglas requested a review from bCatanant March 1, 2021 18:26
@ifdouglas ifdouglas requested a review from Leandroqo March 1, 2021 18:26
@monicaribeiro monicaribeiro merged commit a578993 into main Mar 9, 2021
@monicaribeiro monicaribeiro deleted the issue/user-groups-duplicated branch March 9, 2021 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants