Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[UserGroups] Permission to Maintainer remove Groups from Workspace #930

Merged
merged 20 commits into from
Mar 5, 2021

Conversation

ifdouglas
Copy link
Contributor

@ifdouglas ifdouglas commented Feb 23, 2021

  • Add right permission to maintainers remove groups from workspace
  • Add right message for add group that already was associate to the workspace

Signed-off-by: pedroborgeszup <pedro.borges@zup.com.br>
Signed-off-by: pedroborgeszup <pedro.borges@zup.com.br>
@ifdouglas ifdouglas added bug Something isn't working ui Improvements/additions/fixes for ui module. moove Improvements/additions/fixes for moove module. labels Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #930 (6cacf34) into main (38999fe) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #930      +/-   ##
============================================
+ Coverage     77.25%   77.44%   +0.18%     
  Complexity     1978     1978              
============================================
  Files          1202     1181      -21     
  Lines         17408    16375    -1033     
  Branches       1485     1487       +2     
============================================
- Hits          13449    12681     -768     
+ Misses         3439     3219     -220     
+ Partials        520      475      -45     
Flag Coverage Δ Complexity Δ
compass ? ?
moove 74.07% <ø> (ø) 0.00 <ø> (ø)
ui 80.35% <100.00%> (+0.04%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ttings/Credentials/Sections/UserGroup/constants.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...s/Settings/Credentials/Sections/UserGroup/hooks.ts 87.80% <100.00%> (+9.01%) 0.00 <0.00> (ø)
ui/src/core/utils/auth.ts 85.24% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)
compass/internal/datasource/main.go
compass/internal/datasource/queries.go
compass/internal/moove/moove.go
...ass/internal/metricsgroupaction/actionexecution.go
compass/internal/action/main.go
compass/internal/plugin/main.go
compass/internal/metricsgroup/metricsgroup.go
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e12da...7c5926d. Read the comment docs.

@ifdouglas ifdouglas changed the title [UserGroups] Remove from Workspace [UserGroups] Remove config from Workspace Feb 24, 2021
@ifdouglas ifdouglas marked this pull request as ready for review February 24, 2021 18:52
@ifdouglas ifdouglas changed the title [UserGroups] Remove config from Workspace [UserGroups] Permission to Maintainer to remove Groups from Workspace Feb 25, 2021
@ifdouglas ifdouglas changed the title [UserGroups] Permission to Maintainer to remove Groups from Workspace [UserGroups] Permission to Maintainer remove Groups from Workspace Feb 25, 2021
@monicaribeiro monicaribeiro merged commit 713edab into main Mar 5, 2021
@monicaribeiro monicaribeiro deleted the issue/user-groups branch March 5, 2021 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants