Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Removing unused chart #940

Merged
merged 19 commits into from
Mar 4, 2021
Merged

Removing unused chart #940

merged 19 commits into from
Mar 4, 2021

Conversation

bCatanant
Copy link
Contributor

Removing unused chart on charles C.D.

Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
@bCatanant bCatanant added the ui Improvements/additions/fixes for ui module. label Feb 26, 2021
@bCatanant bCatanant self-assigned this Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #940 (56d093d) into main (24bbc72) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #940      +/-   ##
============================================
+ Coverage     77.19%   77.25%   +0.06%     
  Complexity     1978     1978              
============================================
  Files          1207     1202       -5     
  Lines         16638    17408     +770     
  Branches       1522     1485      -37     
============================================
+ Hits          12844    13449     +605     
- Misses         3312     3439     +127     
- Partials        482      520      +38     
Flag Coverage Δ Complexity Δ
compass 74.68% <100.00%> (?) 0.00 <0.00> (?)
ui 80.31% <100.00%> (+0.59%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
compass/internal/datasource/main.go 100.00% <ø> (ø) 0.00 <0.00> (?)
ui/src/core/components/Page/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Comparation/Item/helpers.ts 96.42% <ø> (+27.53%) 0.00 <0.00> (ø)
ui/src/modules/Circles/Comparation/Item/index.tsx 58.49% <ø> (-0.39%) 0.00 <0.00> (ø)
ui/src/modules/Circles/Comparation/Item/styled.ts 77.27% <ø> (-4.21%) 0.00 <0.00> (ø)
ui/src/modules/Circles/Menu/index.tsx 44.44% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/index.tsx 84.61% <ø> (-0.57%) 0.00 <0.00> (ø)
...tings/Credentials/Sections/MetricProvider/Form.tsx 92.59% <ø> (+2.59%) 0.00 <0.00> (ø)
compass/internal/datasource/datasource.go 82.24% <100.00%> (ø) 0.00 <0.00> (?)
compass/internal/datasource/queries.go 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bbc72...128b317. Read the comment docs.

icaroafonsozup and others added 2 commits March 2, 2021 16:54
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
Copy link
Contributor

@arthurpuccizup arthurpuccizup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the property health in the datasource registration, if there is no more health, this flag is not necessary anymore

maycommit
maycommit previously approved these changes Mar 3, 2021
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
@icaroafonsozup
Copy link
Contributor

Why not remove the property health in the datasource registration, if there is no more health, this flag is not necessary anymore

Property and references removed as asked.

bCatanant and others added 7 commits March 3, 2021 12:42
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
ifdouglas
ifdouglas previously approved these changes Mar 3, 2021
ui/src/modules/Circles/Menu/index.tsx Outdated Show resolved Hide resolved
@bCatanant bCatanant marked this pull request as ready for review March 3, 2021 18:08
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
ifdouglas
ifdouglas previously approved these changes Mar 3, 2021
Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
@ricardorames ricardorames merged commit 38999fe into main Mar 4, 2021
@ricardorames ricardorames deleted the removing-unused-chart branch March 4, 2021 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compass TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants