This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Validation error messages - Error responses pattern #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
See #232
The main goal is to implement the same error format for all our services. This PR implements the error format on validation errors returned by the butler api
Solution
class-validator
package for schema validations with thejoi
package.Results
The error response now has a bit more information about the error, the main benefit will be on the consumer side when all apis of all services implement this format.
Old error response:
Payload:
New error response
Payload: