Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix inconsistently displaying the menu after go to root path #942

Merged
merged 31 commits into from
Mar 19, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Feb 26, 2021

Signed-off-by: luanecavalcantizup luane.cavalcanti@zup.com.br

closes #905

Solution

  • verify user type (root or non-root) and current pathname to return the right menu.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Feb 26, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this Feb 26, 2021
@luanecavalcantizup luanecavalcantizup linked an issue Feb 26, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #942 (1f939df) into main (3bd2555) will increase coverage by 0.87%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #942      +/-   ##
============================================
+ Coverage     76.82%   77.70%   +0.87%     
+ Complexity     2201     1978     -223     
============================================
  Files          1273     1213      -60     
  Lines         18739    16799    -1940     
  Branches       1602     1565      -37     
============================================
- Hits          14397    13054    -1343     
+ Misses         3808     3271     -537     
+ Partials        534      474      -60     
Flag Coverage Δ Complexity Δ
compass ? ?
hermes ? ?
ui 80.80% <81.25%> (+0.03%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Main/Sidebar/MenuItems/index.tsx 94.73% <ø> (+10.52%) 0.00 <0.00> (ø)
ui/src/modules/Main/Sidebar/__tests__/fixtures.ts 0.00% <0.00%> (ø) 0.00 <0.00> (?)
ui/src/modules/Main/Sidebar/helpers.ts 100.00% <100.00%> (+33.33%) 0.00 <0.00> (ø)
ui/src/modules/Main/constants.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/index.tsx 76.00% <100.00%> (+2.08%) 0.00 <0.00> (ø)
...ve/legacy/moove/service/DeploymentServiceLegacy.kt 66.66% <0.00%> (-6.07%) 6.00% <0.00%> (+2.00%) ⬇️
...i/config/DefaultLegacyErrorDecoderConfiguration.kt 80.00% <0.00%> (-4.62%) 2.00% <0.00%> (ø%)
...domain/service/impl/IdentificationServiceImpl.java 91.07% <0.00%> (-3.93%) 29.00% <0.00%> (-15.00%)
...eployment/impl/DeploymentCallbackInteractorImpl.kt 94.28% <0.00%> (-3.59%) 19.00% <0.00%> (-8.00%)
.../deployment/impl/CreateDeploymentInteractorImpl.kt 93.33% <0.00%> (-3.55%) 5.00% <0.00%> (-6.00%)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd2555...1f939df. Read the comment docs.

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review March 1, 2021 21:11
@luanecavalcantizup luanecavalcantizup added the bug Something isn't working label Mar 1, 2021
ifdouglas
ifdouglas previously approved these changes Mar 2, 2021
Leandroqo
Leandroqo previously approved these changes Mar 2, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
luanecavalcantizup and others added 4 commits March 15, 2021 08:08
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
ui/src/modules/Main/constants.ts Outdated Show resolved Hide resolved
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
ifdouglas
ifdouglas previously approved these changes Mar 15, 2021
Leandroqo
Leandroqo previously approved these changes Mar 16, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup merged commit f8ba879 into main Mar 19, 2021
@luanecavalcantizup luanecavalcantizup deleted the fix-menu-route branch March 19, 2021 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistently displaying the menu after go to root path
5 participants