This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Fix showing required for an optional field when registering a module #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanecavalcantizup
changed the title
Fix showing required field for an optional field when registering a module
Fix showing required for an optional field when registering a module
Mar 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
============================================
+ Coverage 77.43% 77.52% +0.08%
Complexity 1978 1978
============================================
Files 1192 1192
Lines 16405 16403 -2
Branches 1491 1491
============================================
+ Hits 12704 12716 +12
+ Misses 3231 3216 -15
- Partials 470 471 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ifdouglas
suggested changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the error prop will just mask the problem, I think this fields shouldn't be required.
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
…nto fix-modules-form-input
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
washingtonsoares
previously approved these changes
Mar 5, 2021
ifdouglas
previously approved these changes
Mar 5, 2021
washingtonsoares
previously approved these changes
Mar 5, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
luanecavalcantizup
dismissed stale reviews from washingtonsoares and ifdouglas
via
March 9, 2021 20:21
ac7a790
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
bCatanant
approved these changes
Mar 10, 2021
monicaribeiro
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: luanecavalcantizup luane.cavalcanti@zup.com.br
Issue Description
When registering a new module, an optional field is shown as required.
Solution
Screenshots (before):