This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Washington Soares <washingtonudi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
============================================
+ Coverage 77.44% 77.48% +0.04%
Complexity 1978 1978
============================================
Files 1181 1192 +11
Lines 16378 16390 +12
Branches 1489 1489
============================================
+ Hits 12684 12700 +16
+ Misses 3219 3217 -2
+ Partials 475 473 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
washingtonsoares
commented
Mar 5, 2021
@@ -0,0 +1,320 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: This is an auto generated file
Signed-off-by: Washington Soares <washingtonudi@gmail.com>
Signed-off-by: Washington Soares <washingtonudi@gmail.com>
…into add-mock-service-worker
bCatanant
previously approved these changes
Mar 8, 2021
luanecavalcantizup
previously approved these changes
Mar 8, 2021
Signed-off-by: Washington Soares <washingtonudi@gmail.com>
washingtonsoares
dismissed stale reviews from luanecavalcantizup and bCatanant
via
March 8, 2021 13:54
145d152
Signed-off-by: Washington Soares <washingtonudi@gmail.com>
bCatanant
approved these changes
Mar 8, 2021
ifdouglas
approved these changes
Mar 8, 2021
Leandroqo
approved these changes
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Currently we don't have a mechanism to mock requests from the backend, moreover, we have a very bad way of mocking requests in unit tests.
Solution
Introducing Mock Service Worker
Mock Service Worker is an API mocking library that uses Service Worker API to intercept actual requests and works fine on both browser and node environment
See more at: https://mswjs.io/docs/