Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Circle creation from CSV file fix #963

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Circle creation from CSV file fix #963

merged 5 commits into from
Mar 8, 2021

Conversation

bCatanant
Copy link
Contributor

Issue Description

When trying to create a circle using the feature from CSV file, after adding a CSV file the front end broke giving the error n.trim is not a function.

Solution

Add a validadion if the file is a string or object.

Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
@bCatanant bCatanant added bug Something isn't working ui Improvements/additions/fixes for ui module. labels Mar 5, 2021
@bCatanant bCatanant self-assigned this Mar 5, 2021
@bCatanant bCatanant changed the title Fix csv bug Circle creation from CSV file fix Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #963 (2ff84a2) into main (713edab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #963   +/-   ##
=========================================
  Coverage     77.44%   77.44%           
  Complexity     1978     1978           
=========================================
  Files          1181     1181           
  Lines         16375    16378    +3     
  Branches       1487     1489    +2     
=========================================
+ Hits          12681    12684    +3     
  Misses         3219     3219           
  Partials        475      475           
Flag Coverage Δ Complexity Δ
ui 80.36% <100.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/hooks/useForm.tsx 80.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/utils/validations.ts 94.44% <100.00%> (+1.11%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7882274...c8d4b86. Read the comment docs.

Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
@bCatanant bCatanant merged commit 1ed5140 into main Mar 8, 2021
@bCatanant bCatanant deleted the fix-csv-bug branch March 8, 2021 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants