Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improve advanced options #981

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Conversation

ifdouglas
Copy link
Contributor

Issue Description

Hidden optional fields were required, preventing submit the form.

Solution

Render the fields only when needed.

@ifdouglas ifdouglas added bug Something isn't working ui Improvements/additions/fixes for ui module. labels Mar 10, 2021
@ifdouglas ifdouglas self-assigned this Mar 10, 2021
Leandroqo
Leandroqo previously approved these changes Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #981 (21b5307) into main (bc34260) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #981      +/-   ##
============================================
+ Coverage     77.43%   77.47%   +0.03%     
  Complexity     1978     1978              
============================================
  Files          1192     1192              
  Lines         16405    16411       +6     
  Branches       1491     1492       +1     
============================================
+ Hits          12704    12714      +10     
+ Misses         3231     3230       -1     
+ Partials        470      467       -3     
Flag Coverage Δ Complexity Δ
ui 80.42% <100.00%> (+0.05%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...src/modules/Modules/Comparation/Form/Component.tsx 80.00% <100.00%> (+9.72%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/Form/styled.ts 92.00% <100.00%> (+3.53%) 0.00 <0.00> (ø)
...loyments/use-cases/paginated-executions.usecase.ts 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3197cbc...6cb4987. Read the comment docs.

@monicaribeiro monicaribeiro merged commit 320e997 into main Mar 16, 2021
@monicaribeiro monicaribeiro deleted the issue/optional-advanced-options branch March 16, 2021 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants