Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Showing in which charles version you are #986

Merged
merged 8 commits into from
Mar 12, 2021
Merged

Showing in which charles version you are #986

merged 8 commits into from
Mar 12, 2021

Conversation

bCatanant
Copy link
Contributor

Issue Description

Impossible to know which version is currently deployed

Solution

add a version on the front end

Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
@bCatanant bCatanant added the ui Improvements/additions/fixes for ui module. label Mar 11, 2021
@bCatanant bCatanant self-assigned this Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #986 (f868503) into main (dcd068f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #986      +/-   ##
============================================
- Coverage     77.51%   77.51%   -0.01%     
  Complexity     1978     1978              
============================================
  Files          1192     1192              
  Lines         16406    16405       -1     
  Branches       1490     1491       +1     
============================================
- Hits          12717    12716       -1     
  Misses         3217     3217              
  Partials        472      472              
Flag Coverage Δ Complexity Δ
ui 80.53% <100.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/providers/base/index.ts 79.62% <100.00%> (+0.38%) 0.00 <0.00> (ø)
ui/src/modules/Main/Footer/index.tsx 85.71% <100.00%> (+2.38%) 0.00 <0.00> (ø)
ui/src/modules/Main/Footer/styled.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...loyments/use-cases/paginated-executions.usecase.ts 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627e6e3...f868503. Read the comment docs.

@bCatanant bCatanant marked this pull request as ready for review March 11, 2021 20:21
lucassaleszup
lucassaleszup previously approved these changes Mar 11, 2021
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Signed-off-by: bCatanant <bruno.catanant@zup.com.br>
Copy link
Contributor

@celiofilhozup celiofilhozup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bCatanant bCatanant merged commit 90f2d0f into main Mar 12, 2021
@bCatanant bCatanant deleted the add-version branch March 12, 2021 15:10
@monicaribeiro monicaribeiro changed the title Add version Showing in which charles version you are Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants