-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## main #996 +/- ##
============================================
+ Coverage 77.53% 77.98% +0.45%
- Complexity 1978 2164 +186
============================================
Files 1234 1242 +8
Lines 17842 17346 -496
Branches 1566 1589 +23
============================================
- Hits 13833 13527 -306
+ Misses 3490 3339 -151
+ Partials 519 480 -39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
...ture/src/main/kotlin/io/charlescd/moove/infrastructure/service/CircleMatcherClientService.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/io/charlescd/moove/application/workspace/impl/PatchWorkspaceInteractorImpl.kt
Show resolved
Hide resolved
.../test/groovy/io/charlescd/moove/infrastructure/service/CircleMatcherClientServiceTest.groovy
Outdated
Show resolved
Hide resolved
if (currentWorkspace.hasCircleMatcher()) { | ||
deleteAllCirclesOnCircleMatcher(currentWorkspace.circleMatcherUrl!!, circles) | ||
} | ||
|
||
if (updatedWorkspace.hasCircleMatcher()) { | ||
deleteAllCirclesOnCircleMatcher(updatedWorkspace.circleMatcherUrl!!, circles) | ||
createAllCirclesOnCircleMatcher(updatedWorkspace.circleMatcherUrl!!, circles) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about the order of this operations, it makes sense to delete all entries on the current matcher before trying to insert on the new one? Cause if we have a problem inserting these entries on the new matcher, we will lose our keys since it was already deleted from the old one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've talked about that. To be sure that everything in the new matcher is brand new, we have to delete that all, and then save everything again. That is the easier way to "sync" the data.
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
…tructure/service/CircleMatcherClientServiceTest.groovy Change spec description Co-authored-by: thallesfreitaszup <56738340+thallesfreitaszup@users.noreply.github.com>
…escd into moove-attach-matcher
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
644b6e2
to
d7efff8
Compare
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
…escd into moove-attach-matcher
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
...ructure/src/main/kotlin/io/charlescd/moove/infrastructure/repository/JdbcCircleRepository.kt
Show resolved
Hide resolved
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
5a312bd
Issue Description
Ao adicionar ou remover um circle matcher do moove, o sistema irá deletar todos os dados do circle matcher, referentes ao workspace corrente.