Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Moove attach matcher #996

Merged
merged 32 commits into from
Apr 7, 2021
Merged

Moove attach matcher #996

merged 32 commits into from
Apr 7, 2021

Conversation

leandrorodrigueszup
Copy link
Contributor

Issue Description

Ao adicionar ou remover um circle matcher do moove, o sistema irá deletar todos os dados do circle matcher, referentes ao workspace corrente.

Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Mar 15, 2021
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #996 (c12c62a) into main (65dea21) will increase coverage by 0.45%.
The diff coverage is 77.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #996      +/-   ##
============================================
+ Coverage     77.53%   77.98%   +0.45%     
- Complexity     1978     2164     +186     
============================================
  Files          1234     1242       +8     
  Lines         17842    17346     -496     
  Branches       1566     1589      +23     
============================================
- Hits          13833    13527     -306     
+ Misses         3490     3339     -151     
+ Partials        519      480      -39     
Flag Coverage Δ Complexity Δ
compass ? ?
moove 75.29% <100.00%> (+1.22%) 0.00 <12.00> (ø)
ui 80.71% <50.00%> (-0.09%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/components/Modal/Trigger/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ttings/Credentials/Sections/CircleMatcher/Form.tsx 63.15% <40.00%> (-16.85%) 0.00 <0.00> (ø)
...tings/Credentials/Sections/CircleMatcher/index.tsx 62.06% <53.33%> (-8.52%) 0.00 <0.00> (ø)
...in/io/charlescd/moove/application/CircleService.kt 84.84% <100.00%> (-15.16%) 11.00 <1.00> (+3.00) ⬇️
...charlescd/moove/application/KeyValueRuleService.kt 100.00% <100.00%> (ø) 4.00 <2.00> (+1.00)
...rcle/impl/UpdateCircleWithCsvFileInteractorImpl.kt 100.00% <100.00%> (ø) 10.00 <0.00> (ø)
...ion/workspace/impl/PatchWorkspaceInteractorImpl.kt 92.85% <100.00%> (-1.27%) 17.00 <6.00> (+1.00) ⬇️
...frastructure/service/CircleMatcherClientService.kt 86.66% <100.00%> (+37.64%) 12.00 <3.00> (+5.00)
...ure/service/client/request/CircleMatcherRequest.kt 66.66% <100.00%> (+10.14%) 10.00 <0.00> (+1.00)
ui/src/core/components/Modal/Trigger/styled.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10f896...c12c62a. Read the comment docs.

Comment on lines +62 to +69
if (currentWorkspace.hasCircleMatcher()) {
deleteAllCirclesOnCircleMatcher(currentWorkspace.circleMatcherUrl!!, circles)
}

if (updatedWorkspace.hasCircleMatcher()) {
deleteAllCirclesOnCircleMatcher(updatedWorkspace.circleMatcherUrl!!, circles)
createAllCirclesOnCircleMatcher(updatedWorkspace.circleMatcherUrl!!, circles)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about the order of this operations, it makes sense to delete all entries on the current matcher before trying to insert on the new one? Cause if we have a problem inserting these entries on the new matcher, we will lose our keys since it was already deleted from the old one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've talked about that. To be sure that everything in the new matcher is brand new, we have to delete that all, and then save everything again. That is the easier way to "sync" the data.

leandrorodrigueszup and others added 7 commits March 17, 2021 10:54
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
…tructure/service/CircleMatcherClientServiceTest.groovy


Change spec description

Co-authored-by: thallesfreitaszup <56738340+thallesfreitaszup@users.noreply.github.com>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@ifdouglas ifdouglas added the ui Improvements/additions/fixes for ui module. label Mar 22, 2021
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@thallesfreitaszup thallesfreitaszup merged commit 826ac3d into main Apr 7, 2021
@thallesfreitaszup thallesfreitaszup deleted the moove-attach-matcher branch April 7, 2021 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants