tests: refactor end-to-end tests #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
lucasbrunozup,
lucasgarciazup,
nathanmartinszup,
nathannascimentozup,
tiagoangelozup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
refactor-e2e-tests
branch
2 times, most recently
from
bffd8d1
to
192cd46
Compare
This commit refactor the end-to-end tests to assert for equal vulnerabilities instead for assert that vulnerabilities is greater than 0. This commit also refactor the tests to use table tests for more readability and avoid duplicated code. Co-authored-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
Co-authored-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
refactor-e2e-tests
branch
from
192cd46
to
fc3f878
Compare
wiliansilvazup
approved these changes
Aug 3, 2021
wiliansilvazup
pushed a commit
that referenced
this pull request
Aug 5, 2021
wiliansilvazup
pushed a commit
that referenced
this pull request
Aug 9, 2021
* tests: refactor end-to-end tests This commit refactor the end-to-end tests to assert for equal vulnerabilities instead for assert that vulnerabilities is greater than 0. This commit also refactor the tests to use table tests for more readability and avoid duplicated code. Co-authored-by: Matheus Alcantara <matheus.alcantara@zup.com.br> * ci: upgrade Go version of e2e to 1.16 Co-authored-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
wiliansilvazup
pushed a commit
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This commit refactor the end-to-end tests to assert for equal
vulnerabilities instead for assert that vulnerabilities is greater
than 0. This commit also refactor the tests to use table tests for more
readability and avoid duplicated code.
- How to verify it
- Description for the changelog