usecases: remove unnecessary partial struct to validate config #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
improvement-usecases
branch
2 times, most recently
from
4c3db9c
to
742601a
Compare
nathanmartinszup
approved these changes
Oct 7, 2021
Previously to validate the user input config we create a new struct `ConfigToValidate` with all the fields of config and them validate, since the fields from config is all public, this commit remove the struct `ConfigToValidate` and check all fields from Config struct directly. An improvement on error message also was made to make it clearer. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
improvement-usecases
branch
from
742601a
to
597dcbf
Compare
wiliansilvazup
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously to validate the user input config we create a new struct
ConfigToValidatewith all the fields of config and them validate,since the fields from config is all public, this commit remove the
struct
ConfigToValidateand check all fields from Config structdirectly. An improvement on error message also was made to make it
clearer.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog