scripts:bugfix - fixing error in url validation with latest rc and beta #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
wiliansilvazup
as code owners
matheusalcantarazup
approved these changes
Dec 15, 2021
iancardosozup
approved these changes
Dec 15, 2021
wiliansilvazup
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating install script validation to cover the beta and rc new tags. The
isOldURL Versionfunction checks for versions before2.6.4, for this the function remove special characters leaving only numbers and verify if the version is greater than the informed version. The validation was not removing beta and rc data from the version. Removed duplicatedechoinforming the version and fixed error in latest versionechoprinting the beta version.Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
- How to verify it
- Description for the changelog